-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JS Guide: Add section on JSDoc usage #41
Comments
From a discussion we had today, e.g. if passing in or returning an anonymous object to be destructured, you might do
or
TBD, but wanted to put down what we discussed. |
I'd also like to land on a guideline of how long the comment lines should be to figure out when to wrap them. Without doing research, I'd land on 80 characters max per line. But I'm open to other suggestions. 🙂 |
I'd like to standardize around that as well. I've been manually doing line breaks where it "feels right" to prevent super long comments, but it would be nice to standardize, lint, and automate this process. 80 seems reasonable — maybe a little long from a typographical perspective where 80 is towards the upper bound of line lengths, but it sounds like a lot of tooling is already built around 80 and I don't think it would impact readability much compared to 60, or 70. |
Resurrecting a previous comment here, we had started to do something like this:
or
Note that primitives are lowercased, otherwise param type is cap-cased. But https://stackoverflow.com/questions/32846527/do-primitive-type-names-need-to-be-uppercase-or-lowercase. Food for thought. |
@tylersticka , I saw you mention an 80 char limit for comments in a PR comment. Should we officially standardize on that? Also, is there a good way to get that to show in VS Code you're aware of? |
ESLint lets you specify a different |
Under Settings, search for "Rulers". Here's my setting: "editor.rulers": [80, 100, 120], |
Oh, sweet. Thanks guys! |
An example:
The text was updated successfully, but these errors were encountered: