Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: move host os and related commands to cloudmesh.common #29

Open
5 of 6 tasks
laszewsk opened this issue May 2, 2022 · 2 comments
Open
5 of 6 tasks

common: move host os and related commands to cloudmesh.common #29

laszewsk opened this issue May 2, 2022 · 2 comments
Assignees
Labels
1 priority one (highest) easy

Comments

@laszewsk
Copy link
Member

laszewsk commented May 2, 2022

  • Gregor: identify def of commands that find os and gitbash use in pi burn and inbventory
  • Gregor: review is cloudmesh.common.systeminfo is good location, yes it is gregor has decided
  • JP: look if in cloudmesh.common are similar commands already elsewhere (e.g. not in systeminfo)
  • JP: move commands to systeminfo
  • JP: provide docstrings
  • Gregor: does a new release

Duration at most 2 hours

cloudmesh burn and possibly cluster contain information about the system that may need to go to cloudmesh.common.sysinfo

This includes figuring out if we are in a gitbash, which OS we have and so on.
Before moving, verify with Gregor and include the links to the URLs of the code, and listthe functions. than we can checkmark the once that we want to move

@jpfleischer jpfleischer added the 2 priority two (high) label May 2, 2022
@laszewsk laszewsk added 1 priority one (highest) and removed 2 priority two (high) labels May 2, 2022
@laszewsk
Copy link
Member Author

laszewsk commented May 4, 2022

gregor can help if you identify where they are in burn or inventory

provide list of the commands and where they are and we move them i think to

cloudmesh.common.sysinfo

@jpfleischer
Copy link
Member

jpfleischer commented May 6, 2022

  • is_cmd_exe
  • is_powershell
  • is_gitbash
  • is_local

#59
cloudmesh/cloudmesh-common#32

these two pull requests feature a migration from burn.util to common.systeminfo

@jpfleischer jpfleischer added question Further information is requested and removed question Further information is requested labels May 13, 2022
@laszewsk laszewsk added the easy label May 27, 2022
@laszewsk laszewsk changed the title move host os and related commands to cloudmesh.common common: move host os and related commands to cloudmesh.common May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 priority one (highest) easy
Projects
None yet
Development

No branches or pull requests

2 participants