From eff37d8d466df9628479c65ba5ef27839b12e07d Mon Sep 17 00:00:00 2001
From: nitrocode <7775707+nitrocode@users.noreply.github.com>
Date: Wed, 6 Jul 2022 12:53:44 -0500
Subject: [PATCH] Override target group name (#63)

* Override target group name

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
---
 .github/renovate.json         |  2 +-
 README.md                     | 35 +++++++++++++++++++++++++----------
 README.yaml                   | 29 +++++++++++++++++++++++------
 docs/terraform.md             |  3 +--
 examples/complete/versions.tf | 10 +---------
 main.tf                       |  2 +-
 variables.tf                  |  6 ++++++
 versions.tf                   |  8 --------
 8 files changed, 58 insertions(+), 37 deletions(-)

diff --git a/.github/renovate.json b/.github/renovate.json
index ae4f0aa..a780298 100644
--- a/.github/renovate.json
+++ b/.github/renovate.json
@@ -4,9 +4,9 @@
     ":preserveSemverRanges"
   ],
   "labels": ["auto-update"],
+  "dependencyDashboardAutoclose": true,
   "enabledManagers": ["terraform"],
   "terraform": {
     "ignorePaths": ["**/context.tf", "examples/**"]
   }
 }
-
diff --git a/README.md b/README.md
index 410787d..d70cc37 100644
--- a/README.md
+++ b/README.md
@@ -105,18 +105,25 @@ provider "aws" {
 }
 
 module "vpc" {
-  source     = "git::https://github.com/cloudposse/terraform-aws-vpc.git?ref=tags/0.8.1"
+  source     = "cloudposse/vpc/aws"
+  # Cloud Posse recommends pinning every module to a specific version
+  # version     = "x.x.x"
+
   namespace  = var.namespace
   stage      = var.stage
   name       = var.name
   delimiter  = var.delimiter
   attributes = var.attributes
   cidr_block = var.vpc_cidr_block
+
   tags       = var.tags
 }
 
 module "subnets" {
-  source               = "git::https://github.com/cloudposse/terraform-aws-dynamic-subnets.git?ref=tags/0.16.1"
+  source = "cloudposse/dynamic-subnets/aws"
+  # Cloud Posse recommends pinning every module to a specific version
+  # version     = "x.x.x"
+
   availability_zones   = var.availability_zones
   namespace            = var.namespace
   stage                = var.stage
@@ -128,11 +135,15 @@ module "subnets" {
   cidr_block           = module.vpc.vpc_cidr_block
   nat_gateway_enabled  = false
   nat_instance_enabled = false
-  tags                 = var.tags
+
+  tags = var.tags
 }
 
 module "alb" {
-  source                                  = "git::https://github.com/cloudposse/terraform-aws-alb.git?ref=tags/0.7.0"
+  source = "cloudposse/alb/aws"
+  # Cloud Posse recommends pinning every module to a specific version
+  # version     = "x.x.x"
+
   namespace                               = var.namespace
   stage                                   = var.stage
   name                                    = var.name
@@ -159,13 +170,15 @@ module "alb" {
   health_check_matcher                    = var.health_check_matcher
   target_group_port                       = var.target_group_port
   target_group_target_type                = var.target_group_target_type
-  tags                                    = var.tags
+
+  tags = var.tags
 }
 
 module "alb_ingress" {
   source = "cloudposse/alb-ingress/aws"
   # Cloud Posse recommends pinning every module to a specific version
   # version     = "x.x.x"
+
   namespace                           = var.namespace
   stage                               = var.stage
   name                                = var.name
@@ -180,7 +193,8 @@ module "alb_ingress" {
   default_target_group_enabled        = false
   target_group_arn                    = module.alb.default_target_group_arn
   unauthenticated_listener_arns       = [module.alb.http_listener_arn]
-  tags                                = var.tags
+
+  tags = var.tags
 }
 ```
 
@@ -208,8 +222,6 @@ Available targets:
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.0 |
 | <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 2.42 |
-| <a name="requirement_local"></a> [local](#requirement\_local) | >= 1.3 |
-| <a name="requirement_null"></a> [null](#requirement\_null) | >= 2.0 |
 
 ## Providers
 
@@ -300,6 +312,7 @@ Available targets:
 | <a name="input_stickiness_type"></a> [stickiness\_type](#input\_stickiness\_type) | The type of sticky sessions. The only current possible value is `lb_cookie` | `string` | `"lb_cookie"` | no |
 | <a name="input_tags"></a> [tags](#input\_tags) | Additional tags (e.g. `{'BusinessUnit': 'XYZ'}`).<br>Neither the tag keys nor the tag values will be modified by this module. | `map(string)` | `{}` | no |
 | <a name="input_target_group_arn"></a> [target\_group\_arn](#input\_target\_group\_arn) | Existing ALB target group ARN. If provided, set `default_target_group_enabled` to `false` to disable creation of the default target group | `string` | `""` | no |
+| <a name="input_target_group_name"></a> [target\_group\_name](#input\_target\_group\_name) | Override the target group name | `string` | `""` | no |
 | <a name="input_target_type"></a> [target\_type](#input\_target\_type) | The type (`instance`, `ip` or `lambda`) of targets that can be registered with the target group | `string` | `"ip"` | no |
 | <a name="input_tenant"></a> [tenant](#input\_tenant) | ID element \_(Rarely used, not included by default)\_. A customer identifier, indicating who this instance of a resource is for | `string` | `null` | no |
 | <a name="input_unauthenticated_hosts"></a> [unauthenticated\_hosts](#input\_unauthenticated\_hosts) | Unauthenticated hosts to match in Hosts header | `list(string)` | `[]` | no |
@@ -462,8 +475,8 @@ Check out [our other projects][github], [follow us on twitter][twitter], [apply
 ### Contributors
 
 <!-- markdownlint-disable -->
-|  [![Erik Osterman][osterman_avatar]][osterman_homepage]<br/>[Erik Osterman][osterman_homepage] | [![Igor Rodionov][goruha_avatar]][goruha_homepage]<br/>[Igor Rodionov][goruha_homepage] | [![Andriy Knysh][aknysh_avatar]][aknysh_homepage]<br/>[Andriy Knysh][aknysh_homepage] | [![Sarkis Varozian][sarkis_avatar]][sarkis_homepage]<br/>[Sarkis Varozian][sarkis_homepage] |
-|---|---|---|---|
+|  [![Erik Osterman][osterman_avatar]][osterman_homepage]<br/>[Erik Osterman][osterman_homepage] | [![Igor Rodionov][goruha_avatar]][goruha_homepage]<br/>[Igor Rodionov][goruha_homepage] | [![Andriy Knysh][aknysh_avatar]][aknysh_homepage]<br/>[Andriy Knysh][aknysh_homepage] | [![Sarkis Varozian][sarkis_avatar]][sarkis_homepage]<br/>[Sarkis Varozian][sarkis_homepage] | [![RB][nitrocode_avatar]][nitrocode_homepage]<br/>[RB][nitrocode_homepage] |
+|---|---|---|---|---|
 <!-- markdownlint-restore -->
 
   [osterman_homepage]: https://github.com/osterman
@@ -474,6 +487,8 @@ Check out [our other projects][github], [follow us on twitter][twitter], [apply
   [aknysh_avatar]: https://img.cloudposse.com/150x150/https://github.com/aknysh.png
   [sarkis_homepage]: https://github.com/sarkis
   [sarkis_avatar]: https://img.cloudposse.com/150x150/https://github.com/sarkis.png
+  [nitrocode_homepage]: https://github.com/nitrocode
+  [nitrocode_avatar]: https://img.cloudposse.com/150x150/https://github.com/nitrocode.png
 
 [![README Footer][readme_footer_img]][readme_footer_link]
 [![Beacon][beacon]][website]
diff --git a/README.yaml b/README.yaml
index aa39601..902cb38 100644
--- a/README.yaml
+++ b/README.yaml
@@ -28,18 +28,25 @@ usage: |-
   }
 
   module "vpc" {
-    source     = "git::https://github.com/cloudposse/terraform-aws-vpc.git?ref=tags/0.8.1"
+    source     = "cloudposse/vpc/aws"
+    # Cloud Posse recommends pinning every module to a specific version
+    # version     = "x.x.x"
+
     namespace  = var.namespace
     stage      = var.stage
     name       = var.name
     delimiter  = var.delimiter
     attributes = var.attributes
     cidr_block = var.vpc_cidr_block
+
     tags       = var.tags
   }
 
   module "subnets" {
-    source               = "git::https://github.com/cloudposse/terraform-aws-dynamic-subnets.git?ref=tags/0.16.1"
+    source = "cloudposse/dynamic-subnets/aws"
+    # Cloud Posse recommends pinning every module to a specific version
+    # version     = "x.x.x"
+
     availability_zones   = var.availability_zones
     namespace            = var.namespace
     stage                = var.stage
@@ -51,11 +58,15 @@ usage: |-
     cidr_block           = module.vpc.vpc_cidr_block
     nat_gateway_enabled  = false
     nat_instance_enabled = false
-    tags                 = var.tags
+
+    tags = var.tags
   }
 
   module "alb" {
-    source                                  = "git::https://github.com/cloudposse/terraform-aws-alb.git?ref=tags/0.7.0"
+    source = "cloudposse/alb/aws"
+    # Cloud Posse recommends pinning every module to a specific version
+    # version     = "x.x.x"
+
     namespace                               = var.namespace
     stage                                   = var.stage
     name                                    = var.name
@@ -82,13 +93,15 @@ usage: |-
     health_check_matcher                    = var.health_check_matcher
     target_group_port                       = var.target_group_port
     target_group_target_type                = var.target_group_target_type
-    tags                                    = var.tags
+
+    tags = var.tags
   }
 
   module "alb_ingress" {
     source = "cloudposse/alb-ingress/aws"
     # Cloud Posse recommends pinning every module to a specific version
     # version     = "x.x.x"
+
     namespace                           = var.namespace
     stage                               = var.stage
     name                                = var.name
@@ -103,9 +116,11 @@ usage: |-
     default_target_group_enabled        = false
     target_group_arn                    = module.alb.default_target_group_arn
     unauthenticated_listener_arns       = [module.alb.http_listener_arn]
-    tags                                = var.tags
+
+    tags = var.tags
   }
   ```
+
 include:
 - docs/targets.md
 - docs/terraform.md
@@ -118,3 +133,5 @@ contributors:
   github: aknysh
 - name: Sarkis Varozian
   github: sarkis
+- name: RB
+  github: nitrocode
diff --git a/docs/terraform.md b/docs/terraform.md
index c468fbe..098d49d 100644
--- a/docs/terraform.md
+++ b/docs/terraform.md
@@ -5,8 +5,6 @@
 |------|---------|
 | <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 0.13.0 |
 | <a name="requirement_aws"></a> [aws](#requirement\_aws) | >= 2.42 |
-| <a name="requirement_local"></a> [local](#requirement\_local) | >= 1.3 |
-| <a name="requirement_null"></a> [null](#requirement\_null) | >= 2.0 |
 
 ## Providers
 
@@ -97,6 +95,7 @@
 | <a name="input_stickiness_type"></a> [stickiness\_type](#input\_stickiness\_type) | The type of sticky sessions. The only current possible value is `lb_cookie` | `string` | `"lb_cookie"` | no |
 | <a name="input_tags"></a> [tags](#input\_tags) | Additional tags (e.g. `{'BusinessUnit': 'XYZ'}`).<br>Neither the tag keys nor the tag values will be modified by this module. | `map(string)` | `{}` | no |
 | <a name="input_target_group_arn"></a> [target\_group\_arn](#input\_target\_group\_arn) | Existing ALB target group ARN. If provided, set `default_target_group_enabled` to `false` to disable creation of the default target group | `string` | `""` | no |
+| <a name="input_target_group_name"></a> [target\_group\_name](#input\_target\_group\_name) | Override the target group name | `string` | `""` | no |
 | <a name="input_target_type"></a> [target\_type](#input\_target\_type) | The type (`instance`, `ip` or `lambda`) of targets that can be registered with the target group | `string` | `"ip"` | no |
 | <a name="input_tenant"></a> [tenant](#input\_tenant) | ID element \_(Rarely used, not included by default)\_. A customer identifier, indicating who this instance of a resource is for | `string` | `null` | no |
 | <a name="input_unauthenticated_hosts"></a> [unauthenticated\_hosts](#input\_unauthenticated\_hosts) | Unauthenticated hosts to match in Hosts header | `list(string)` | `[]` | no |
diff --git a/examples/complete/versions.tf b/examples/complete/versions.tf
index 41d4fad..e3a93bb 100644
--- a/examples/complete/versions.tf
+++ b/examples/complete/versions.tf
@@ -4,15 +4,7 @@ terraform {
   required_providers {
     aws = {
       source  = "hashicorp/aws"
-      version = ">= 2.0"
-    }
-    null = {
-      source  = "hashicorp/null"
-      version = ">= 2.0"
-    }
-    local = {
-      source  = "hashicorp/local"
-      version = ">= 1.3"
+      version = ">= 2.42"
     }
   }
 }
diff --git a/main.tf b/main.tf
index 93ac4ea..75ab6b7 100644
--- a/main.tf
+++ b/main.tf
@@ -11,7 +11,7 @@ data "aws_lb_target_group" "default" {
 resource "aws_lb_target_group" "default" {
   count = module.this.enabled && var.default_target_group_enabled ? 1 : 0
 
-  name        = module.this.id
+  name        = coalesce(var.target_group_name, module.this.id)
   port        = var.port
   protocol    = var.protocol
   slow_start  = var.slow_start
diff --git a/variables.tf b/variables.tf
index 4a77aa4..33f313b 100644
--- a/variables.tf
+++ b/variables.tf
@@ -121,6 +121,12 @@ variable "protocol" {
   description = "The protocol for the created ALB target group (if `target_group_arn` is not set)"
 }
 
+variable "target_group_name" {
+  type        = string
+  default     = ""
+  description = "Override the target group name"
+}
+
 variable "target_type" {
   type        = string
   default     = "ip"
diff --git a/versions.tf b/versions.tf
index d6cca7b..e3a93bb 100644
--- a/versions.tf
+++ b/versions.tf
@@ -6,13 +6,5 @@ terraform {
       source  = "hashicorp/aws"
       version = ">= 2.42"
     }
-    null = {
-      source  = "hashicorp/null"
-      version = ">= 2.0"
-    }
-    local = {
-      source  = "hashicorp/local"
-      version = ">= 1.3"
-    }
   }
 }