Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support bootstrap_self_managed_addons #236

Merged

Conversation

sergeyrudenko111
Copy link
Contributor

what

  • Add support of bootstrap_self_managed_addons for aws_eks_cluster resource

why

  • This change will provide an opportunity to not bootstrap default networking addons for new cluster

references

https://aws.amazon.com/about-aws/whats-new/2024/06/amazon-eks-cluster-creation-flexibility-networking-add-ons/

@sergeyrudenko111 sergeyrudenko111 requested review from a team as code owners August 14, 2024 08:25
@mergify mergify bot added the triage Needs triage label Aug 14, 2024
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request, otherwise looking good 👍

variables.tf Outdated Show resolved Hide resolved
@Gowiem
Copy link
Member

Gowiem commented Aug 22, 2024

/terratest

@Gowiem Gowiem added enhancement New feature or request minor New features that do not break anything labels Aug 22, 2024
@Gowiem
Copy link
Member

Gowiem commented Aug 22, 2024

@sergeyrudenko111 looks like you need to bump the minimum provider version:

│ Error: Unsupported argument
        	            	│ 
        	            	│   on main.tf line 115, in module "eks_cluster":
        	            	│  115:   bootstrap_self_managed_addons = var.bootstrap_self_managed_addons_enabled
        	            	│ 
        	            	│ An argument named "bootstrap_self_managed_addons" is not expected here.

@sergeyrudenko111
Copy link
Contributor Author

@Gowiem forgot to apply a variable name change from previous commit to examples/complete/main.tf, now terratest should pass.

@Gowiem
Copy link
Member

Gowiem commented Aug 23, 2024

/terratest

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gowiem Gowiem merged commit 76ed997 into cloudposse:main Aug 24, 2024
15 checks passed
@mergify mergify bot removed the triage Needs triage label Aug 24, 2024
Copy link

These changes were released in v4.4.0.

@Nuru
Copy link
Contributor

Nuru commented Aug 27, 2024

@Gowiem You were right, but our Terratests don't check for this.

AWS Provider version requirement needs to be bumped to v5.58.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants