Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Show TextFilter count text in inactive/disabled color when loading #3160

Open
2 tasks done
phuctm97 opened this issue Dec 28, 2024 · 3 comments
Open
2 tasks done
Labels
enhancement New feature or request

Comments

@phuctm97
Copy link

Description

Collection filter components has countText and loading props to display the number of matched results:

  • countText always shows & triggers screen readers when there are filters
  • loading delays screen readers to announce countText until it's false because the current countText may be out of date.
    It would make a lot of sense and a great user experience to show the countText in inactive/disabled status to indicate that it's out of date.
    Alternative solution is to have more specific loading/stale indicator for countText, but I think simply showing it in inactive/disabled color is already a great solution.

Code of Conduct

@phuctm97 phuctm97 added the enhancement New feature or request label Dec 28, 2024
@cansuaa
Copy link
Contributor

cansuaa commented Jan 7, 2025

Hi, thanks for reaching out. Adding a visual indicator of loading to the count text does seem like a sensible addition to the text filter component, however we don’t have any plans for making this change at the moment.

@phuctm97
Copy link
Author

phuctm97 commented Jan 9, 2025

Hi, thanks for reaching out. Adding a visual indicator of loading to the count text does seem like a sensible addition to the text filter component, however we don’t have any plans for making this change at the moment.

Would you guys accept a PR for this though? It seems to be a very simple PR and I'm willing to submit it.

@at-susie
Copy link
Member

Hi @phuctm97,

Thanks for your feedback on the collection filter. To help us better understand the issue and find the best solution, could you please provide a bit more context on the following:

  • Use case: Can you describe typical use cases where users would rely on the countText while filtering? How important is it that the count is always up-to-date, given it's pretty smooth and quick to be updated?
  • Impact of outdated count: What problems have you noticed when the countText is out of date during the loading phase?
  • Screen reader behavior: Sounds like your primary concerns may relate to screen reader experiences. If so, did you notice any issues with how the countText is announced while loading?

Best regards,
Atsushi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants