Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility: CREATE/DROP/ALTER MODEL statements(a.k.a. Vertex AI integration) are not supported #96

Closed
apstndb opened this issue Sep 12, 2024 · 0 comments · Fixed by #195

Comments

@apstndb
Copy link
Contributor

apstndb commented Sep 12, 2024

This incompatibility is detected by #90.

Spec

https://cloud.google.com/spanner/docs/reference/standard-sql/data-definition-language#model_statements

{ CREATE MODEL | CREATE OR REPLACE MODEL | CREATE MODEL IF NOT EXISTS } model_name
[INPUT ( column_list ) OUTPUT ( column_list )]
REMOTE
[OPTIONS ( model_options )]

where column_list is:
   { column_name data_type [OPTIONS ( model_column_options )] [, ... ] }

and model_column_options is:
    {
      required = { true | false }
    }

and model_options is:
    {
      endpoint = '{endpoint_address}',
      endpoints = [ '{endpoint_address}' [, ...] ],
      default_batch_size = int64_value
    }

https://cloud.google.com/spanner/docs/reference/standard-sql/data-definition-language#alter-model

ALTER MODEL [ IF EXISTS ] model_name
SET OPTIONS ( model_options )

where model_options is:
    {
      endpoint = '{endpoint_address}',
      endpoints = [ '{endpoint_address}' [, ...] ],
      default_batch_size = int64_value
    }

https://cloud.google.com/spanner/docs/reference/standard-sql/data-definition-language#drop-model

DROP MODEL [ IF EXISTS ] model_name

Reproducing input

CREATE MODEL m1
INPUT( feature INT64 )
OUTPUT( label STRING(MAX) )
REMOTE OPTIONS (
  endpoint = '//aiplatform.googleapis.com/projects/tp/locations/tl/endpoints/schemaless'
);

Current error

syntax error:testdata/models.test:4:8: expected pseudo keyword: DATABASE, TABLE, INDEX, UNIQUE, NULL_FILTERED, ROLE, CHANGE but: MODEL

  4:  CREATE MODEL m1
             ^~~~~

Related update of this syntax

https://cloud.google.com/spanner/docs/release-notes#October_11_2022

@apstndb apstndb changed the title Incompatibilities: CREATE/DROP/ALTER MODEL statements(a.k.a. Vertex AI integration) are not supported Incompatibility: CREATE/DROP/ALTER MODEL statements(a.k.a. Vertex AI integration) are not supported Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant