Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: migrate spansql with memefish #118

Closed
apstndb opened this issue Sep 20, 2024 · 1 comment · Fixed by #121
Closed

Proposal: migrate spansql with memefish #118

apstndb opened this issue Sep 20, 2024 · 1 comment · Fixed by #121
Labels
enhancement New feature or request

Comments

@apstndb
Copy link
Contributor

apstndb commented Sep 20, 2024

WHAT

I think it is better to replace spansql with memefish in wrench.

WHY

Related discussion: #83

It seems that wrench users sometimes contribute spansql to fix their issues, but it is considered a loss of community resources.
https://github.com/googleapis/google-cloud-go/commits/main/spanner/spansql

spansql has many incompatibilities, and it seems no chance to become a real SQL parser.
It don't support basic SQL feature like subqueries.

result of memefish test cases in spansql: https://github.com/apstndb/spansql-testsuite/blob/abc0bd3c3ee11f53d81c6f83f0494b56fba9ee20/output/result.csv

@apstndb apstndb added the enhancement New feature or request label Sep 20, 2024
@apstndb
Copy link
Contributor Author

apstndb commented Nov 8, 2024

memefish has already passed all spansql test cases.
cloudspannerecosystem/memefish#115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant