-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undefined Behaviour: This crate doesn't check for cpu flags #74
Comments
low-level SIMD instructions are not supported for MIRI, and the work is in progress. #61 |
If you implement feature detection correctly, Miri should report that it doesn't support avx and you can take the fallback path. |
yes, there is a TODO here and I ignored it... I will fixed it... https://github.com/cloudwego/sonic-rs/blob/main/src/util/arch/mod.rs#L2 |
Fixed in v0.3.5 |
Describe the bug
This crate has UB on cpus without avx support
To Reproduce
cargo +nightly miri run
on a function that hassonic_rs::from_str
Expected behavior
A panic if the target doesn't support avx
Screenshots
The text was updated successfully, but these errors were encountered: