Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP Notices #3

Open
jeremylichtman opened this issue Sep 1, 2017 · 1 comment
Open

Fix PHP Notices #3

jeremylichtman opened this issue Sep 1, 2017 · 1 comment

Comments

@jeremylichtman
Copy link

The following patch fixes items in the module file that were causing PHP notices, which in turn prevented the AJAX callback from completing.

  1. Switches to checking the project's published status, instead of the old reason_not_active field, which doesn't exist any more.
  2. Moves the location where the "has_results" variable is set to true, to inside of the "if" statement that determines if there is a result.
  3. Defaults the "html" variable to an empty string at the top of the function.

fix-results-status.txt

@libkuman
Copy link

libkuman commented Sep 1, 2017

This looks good. A lot of these modules were developed with php notices turned off so you'll probably encounter them frequently. Once we give a test of this it'll be nice to roll it into the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants