Skip to content

Latest commit

 

History

History
154 lines (97 loc) · 5.38 KB

CONTRIBUTING.rst

File metadata and controls

154 lines (97 loc) · 5.38 KB

Contributing

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions

Report Bugs

Report bugs at https://github.com/cmollet/sridentify/issues

If you are reporting a bug, please include:

  • Your operating system name and version.
  • Your Python version (the output of python --version).
  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" and "help wanted" is open to whoever wants to implement a fix for it.

Implement Features

Look through the GitHub issues for features. Anything tagged with "enhancement" and "help wanted" is open to whoever wants to implement it.

Write Documentation

sridentify could always use more documentation, whether as part of the official docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/cmollet/sridentify/issues.

If you are proposing a new feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.
  • Remember that this is a volunteer-driven project, and that contributions are welcome :)

About the epsg.db database

As stated in README.rst, the database shipped with this project contains a set of known WKT projection strings. The database is a sqlite file, and users have full control over it. They can add, modify, or delete any record in there, and one feature of this library is the ability to query the prj2epsg.org API against a WKT string not in the database and save the result if a match was found. The database should be kept in a known good baseline state that individual users can modify as needed on a per-project basis. This means that pull requests that modify the epsg.db database will not be accepted.

Get Started!

Ready to contribute? Here's how to set up sridentify for local development. Please note this documentation assumes you already have virtualenv and Git installed and ready to go.

  1. Fork the cmollet/sridentify repo on GitHub.
  2. Clone your fork locally:
$ cd path_for_the_repo
$ git clone [email protected]:YOUR_NAME/sridentify
  1. Assuming you have virtualenv installed (If you have Python>=3.5 this should already be there), you can create a new environment for your local development by typing:
$ virtualenv sridentify-env
$ source sridentify-env/bin/activate

# This should change the shell to look something like
(sridentify-env) $
# Now you can setup your development environment
$ python setup.py develop
  1. Create a branch for local development:
$ git checkout -b name-of-your-bugfix-or-feature

Now you can make your changes locally.

  1. The next step would be to run the test cases.
$ python setup.py test
  1. If your contribution is a bug fix or new feature, you may want to add a test to the existing test suite. See section Add a New Test below for details.
  2. Commit your changes and push your branch to GitHub:
$ git add .
$ git commit -m "Your detailed description of your changes."
$ git push origin name-of-your-bugfix-or-feature
  1. Submit a pull request through the GitHub website.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

  1. The pull request should include tests.
  2. If the pull request adds functionality, the docs should be updated. Put your new functionality into a function with a docstring, and add the feature to the list in README.rst.
  3. The pull request should work for Python 2.7, 3.4, 3.5 and 3.6, and for Anaconda 3.

Add a New Test

When fixing a bug or adding features, it's good practice to add a test to demonstrate your fix or new feature behaves as expected. These tests should focus on one tiny bit of functionality and prove changes are correct.

To write and run your new test, follow these steps:

  1. Add the new test to the appropriate test file in tests/ (i.e., if your test is for the Python API, add it to tests/test_api_mode.py). Focus your test on the specific bug or a small part of the new feature.

  2. If you have already made changes to the code, stash your changes and confirm all your changes were stashed:

    $ git stash
$ git stash list

  3. Run your test and confirm that your test fails. If your test does not fail, rewrite the test until it fails on the original code:

    $ python setup.py test

  4. Proceed work on your bug fix or new feature or restore your changes. To restore your stashed changes and confirm their restoration:

    $ git stash pop
$ git stash list

  5. Rerun your test and confirm that your test passes. If it passes, congratulations!