Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branches to the flat trees #1

Open
rmanzoni opened this issue Jun 21, 2016 · 9 comments
Open

Add branches to the flat trees #1

rmanzoni opened this issue Jun 21, 2016 · 9 comments
Assignees

Comments

@rmanzoni
Copy link
Contributor

rmanzoni commented Jun 21, 2016

Hi,

Nice job!

it would be useful to also save:

Then it may be worth relaxing a some selection criteria and have the possibility of applying them at the plotting stage. For example:

  • sign of the mu+tau pair
  • transverse mass (we may want to tighten or invert depending on the quantity we want to investigate)
  • mass of mu+tau pair

Thanks!
Ric

@mbluj
Copy link
Contributor

mbluj commented Jun 21, 2016

Hi guys, it is really nice progress, thanks!
What about presenting the tool (+some results) on a coming tau meeting, e.g. on next or next-to-next Monday?

@l-cadamuro
Copy link
Contributor

Hi, thanks a lot!
For Riccardo's last points, they are now required in the TauTagAndProbe plugin, so one can simply produce a new collection with these values and remove the "return false" statement.
Same for the additional branches (I think L1 is stored into a separate collection of l1t::Tau, so it requires a separate matching loop but It will be fast to do ;-) )
Michal, would it be fine to present next-to-next Monday? Next week there will be the preapprovals so there's some risk of overlaps.
Cheers,
Luca

@mbluj
Copy link
Contributor

mbluj commented Jun 21, 2016

Concerning selections at TauTagAndProbe plugin: I agree with Riccardo that it is good to have them reasonably loose to have possibility to check efficiency for different selections (signal-like, W/QCD background enriched, etc.) w/o need of rerunning which takes some time at big datasets. Another solution can be run a few plugins with different selections in parallel in one job. Anyway, it makes sense to have some basic cuts like mass window, OS on/off, Mt </> a threshold configurable via python cfi. What do you think?

Concerning presentation: both dates are fine, just ask before a weekend to be added to agenda on following Monday.

@l-cadamuro
Copy link
Contributor

Hi Michal,

ok agreed, I think each value on which we want to cut can be stored in the output ntuple, and the cut applied at plotting level. This also guarantees that we select only 1 mu-tau pair per event, and only later select candidates from Z->tautau or background.
I will do these changes as soon as possible.

@rmanzoni , can you link/upload the plotting code to see how it can be configured to handle this?

For the presentation, we will ask with the necessary advance!

@mbluj
Copy link
Contributor

mbluj commented Jun 21, 2016

Yes, right. The most difficult is to make a book keeping which will allow to select only one pair per an event. You can solve this issue either by preforming an arbitration at CMSSW plugin level (as currently done) but it requires some arbitrary decision at early stage or store a couple of pairs (hopefully the number is not high for tight muon not-so-loose tau) and then decide at plotting level. Finally, you can accept more than one pair per an event for the measurement but it is not preferred solution as it decreases purity.

@rmanzoni
Copy link
Contributor Author

@l-cadamuro have a look here
https://github.com/rmanzoni/triggertools
as is, it is standalone, but it would be nice to have it integrated in this repository itself.
I'll push it under this repository's python folder and let you adjust the imports accordingly.

@rmanzoni
Copy link
Contributor Author

there is some clutter, but that's the best I can do so sneakily
https://github.com/cms-tau-pog/TauTriggerValidation/tree/master/TauTriggerValidation/python

@uhussain
Copy link
Contributor

Hi all,

In the meantime, i’m trying to add the variables suggested by Riccardo to the analyzer and then updating the filters next appropriate to 2016 data. I am figuring this out as I work on this project so i appreciate the input and suggestions.

Thanks,
Usama

On Jun 21, 2016, at 1:49 PM, Riccardo Manzoni [email protected] wrote:

@l-cadamuro https://github.com/l-cadamuro have a look here
https://github.com/rmanzoni/triggertools https://github.com/rmanzoni/triggertools
as is, it is standalone, but it would be nice to have it integrated in this repository itself.
I'll push it under this repository's python folder and let you adjust the imports accordingly.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub #1 (comment), or mute the thread https://github.com/notifications/unsubscribe/ACN6mbl56J1tLXj9bNiSh0W_14uQYl4cks5qN8_agaJpZM4I6k0J.

@uhussain
Copy link
Contributor

Hi everyone,

I pushed some changes to the repository mainly adding the branches that riccardo mentioned and storing pT, eta, phi for l1taus as well. I made a new branch "mydev" for these changes just in case we need to refine the selection criteria for the matching or need to alter things that i might have added and are not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants