diff --git a/.github/workflows/tests_ci.yaml b/.github/workflows/tests_ci.yaml index 52d27924..37a43ed4 100644 --- a/.github/workflows/tests_ci.yaml +++ b/.github/workflows/tests_ci.yaml @@ -45,14 +45,14 @@ jobs: # Unit tests are defined as tests which don't require any external systems to be running. run: | . "$HOME/.cargo/env" - ./scripts/run_unit_tests.py + ./scripts/run_unit_tests.sh - name: Run integration tests # Integration tests do require external systems to be running (most commonly a database instance). # Unlike end-to-end tests though, they test a specific module in a detailed manner, much like a unit test does. run: | . "$HOME/.cargo/env" - ./scripts/run_integration_tests.py + ./scripts/run_integration_tests.sh - name: Run end-to-end tests # End-to-end tests are like integration tests in that they require external systems to be running. diff --git a/tune/env/integtest_pg_conn.py b/tune/env/integtest_pg_conn.py index b801fb68..c466aa0a 100644 --- a/tune/env/integtest_pg_conn.py +++ b/tune/env/integtest_pg_conn.py @@ -39,7 +39,11 @@ def setUpClass() -> None: PostgresConnTests.dbgym_cfg = DBGymConfig(ENV_TESTS_DBGYM_CONFIG_FPATH) def setUp(self) -> None: - self.assertFalse(get_is_postgres_running()) + self.assertFalse( + get_is_postgres_running(), + "Make sure Postgres isn't running before starting the integration test. `pkill postgres` is one way" + + "to ensure this. Be careful about accidentally taking down other people's Postgres instances though." + ) self.pristine_dbdata_snapshot_path = default_pristine_dbdata_snapshot_path( self.dbgym_cfg.dbgym_workspace_path, BENCHMARK, SCALE_FACTOR )