-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update database drivers #1355
Comments
I went looking for places these db packages are actually referenced/used...
In all of our python ( https://github.com/search?q=repo%3Acmu-delphi%2Fdelphi-epidata+%2Fmysql%2F+language%3Apython&type=code ), we really only use In non-python ( https://github.com/search?q=repo%3Acmu-delphi%2Fdelphi-epidata+%2Fmysql%2F+-language%3Apython&type=code ), the only places we see It seems silly to use two different adapters/drivers across this single repository. I was going to suggest settling on using only So, at this point, we can either:
|
After all of the SQLAlchemy talk, it occurs to me that its probably worth it to bump its version too. The version we are currently using (1.4.40) is about 1.5y old. There is a new major release, but also very recent maintenance releases to the minor version we are already using. Our uses of the package are fairly simplistic, so it is probably low risk to attempt the major. |
We pin the version on 3 database-specific (MySQL) packages. They are all getting long in the tooth. Updating them could give us better performance, but might also cause problems or require non-trivial changes:
delphi-epidata/requirements.api.txt
Line 7 in bc7e375
delphi-epidata/requirements.dev.txt
Line 16 in bc7e375
delphi-epidata/requirements.dev.txt
Line 13 in bc7e375
The text was updated successfully, but these errors were encountered: