[Draft]: Calculate local markov blanket against true graph for parted nodes that passed AD Test #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbcwonderland
commented
Apr 9, 2024
| @@ -103,7 +103,7 @@ public static boolean isClique(Collection<Node> set, Graph graph) { | |||
| * @param graph a DAG, CPDAG, MAG, or PAG. | |||
| * @return a {@link edu.cmu.tetrad.graph.Graph} object | |||
| */ | |||
| public static Graph markovBlanketSubgraph(Node target, Graph graph) { | |||
| public static Graph markovBlanketSubgraph(Node target, Graph graph) { // TODO VBC: @Joe is this the more general method you recommended? | |||
There was a problem hiding this comment.
@jdramsey for confirmation :D
There was a problem hiding this comment.
This is the method I had in mind:
public Graph getMarkovBlanketSubgraph(Graph graph, Node targetNode) {
EdgeListGraph g = new EdgeListGraph();
Set<Node> nodes = GraphUtils.markovBlanket(targetNode, g);
return g.subgraph(new ArrayList<>(nodes));
}
You could put that method somewhere helpful; it may not already exist in the code.
vbcwonderland
commented
Apr 9, 2024
|
|
||
| double precision = (double) truePositive.size() / xMBLookupGraphEdges.size(); | ||
| double recall = (double) truePositive.size() / xMBEstimatedGraphEdges.size(); | ||
| return getPrecision ? precision : recall; |
There was a problem hiding this comment.
These outprints seems correct to me, maybe you want a second check : )
vbcwonderland
commented
Apr 9, 2024
| System.out.println("@@@@@@@@@@@@@@@@"); | ||
|
|
||
| HashSet<Edge> truePositive = new HashSet<>(xMBEstimatedGraphEdges); | ||
| // TODO VBC: QUESTION FOr DISCUSSION |
There was a problem hiding this comment.
@jdramsey We need to discuss this tho
|
As for what exactly to report, I think I would myself need input from Peter here. What you're reporting sounds fine to me, but he may want something different... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP! Need to check with Joe on how to find a node in estimated graph's corresponding node in the true graph. I tried using node's name, but it doesnt seem to work from unit test result.