Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes for some warnings #254

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Minor fixes for some warnings #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02a62ac
Removed const-qualifiers from return-by-value, where they have no effect
emmenlau Oct 10, 2024
e76ec7d
src/qanNavigable.h: Minor warning fixed, about unused variable
emmenlau Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/qanGroupItem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,7 @@ bool GroupItem::setDragPolicy(DragPolicy dragPolicy) noexcept
}
return false;
}
GroupItem::DragPolicy GroupItem::getDragPolicy() noexcept { return _dragPolicy; }
const GroupItem::DragPolicy GroupItem::getDragPolicy() const noexcept { return _dragPolicy; }
GroupItem::DragPolicy GroupItem::getDragPolicy() const noexcept { return _dragPolicy; }

void GroupItem::groupMoved()
{
Expand Down
4 changes: 1 addition & 3 deletions src/qanGroupItem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,7 @@ class GroupItem : public qan::NodeItem
//! \copydoc DragPolicy
virtual bool setDragPolicy(DragPolicy dragPolicy) noexcept;
//! \copydoc DragPolicy
DragPolicy getDragPolicy() noexcept;
//! \copydoc DragPolicy
const DragPolicy getDragPolicy() const noexcept;
DragPolicy getDragPolicy() const noexcept;
protected:
//! \copydoc DragPolicy
DragPolicy _dragPolicy = DragPolicy::Header;
Expand Down
4 changes: 2 additions & 2 deletions src/qanNavigable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,9 +348,9 @@ protected slots:

protected:
//! Called when the mouse is clicked in the container (base implementation empty).
virtual void navigableClicked(QPointF pos, QPointF globalPos) { Q_UNUSED(pos); }
virtual void navigableClicked(QPointF pos, QPointF globalPos) { Q_UNUSED(pos); Q_UNUSED(globalPos); }
//! Called when the mouse is right clicked in the container (base implementation empty).
virtual void navigableRightClicked(QPointF pos, QPointF globalPos) { Q_UNUSED(pos); }
virtual void navigableRightClicked(QPointF pos, QPointF globalPos) { Q_UNUSED(pos); Q_UNUSED(globalPos); }
//! Called when the container item is scaled (zoomed) or panned (base implementation empty).
virtual void navigableContainerItemModified() { }

Expand Down
3 changes: 1 addition & 2 deletions src/qanTreeLayouts.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,7 @@ bool OrgTreeLayout::setLayoutOrientation(OrgTreeLayout::LayoutOrientation lay
}
return false;
}
OrgTreeLayout::LayoutOrientation OrgTreeLayout::getLayoutOrientation() noexcept { return _layoutOrientation; }
const OrgTreeLayout::LayoutOrientation OrgTreeLayout::getLayoutOrientation() const noexcept { return _layoutOrientation; }
OrgTreeLayout::LayoutOrientation OrgTreeLayout::getLayoutOrientation() const noexcept { return _layoutOrientation; }


void OrgTreeLayout::layout(qan::Node& root, qreal xSpacing, qreal ySpacing) noexcept
Expand Down
5 changes: 1 addition & 4 deletions src/qanTreeLayouts.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,7 @@ class OrgTreeLayout : public QObject
//! \copydoc LayoutOrientation
bool setLayoutOrientation(LayoutOrientation layoutOrientation) noexcept;
//! \copydoc LayoutOrientation
LayoutOrientation getLayoutOrientation() noexcept;
//! \copydoc LayoutOrientation
const LayoutOrientation getLayoutOrientation() const noexcept;
LayoutOrientation getLayoutOrientation() const noexcept;
protected:
//! \copydoc LayoutOrientation
LayoutOrientation _layoutOrientation = LayoutOrientation::Vertical;
Expand Down Expand Up @@ -195,4 +193,3 @@ class OrgTreeLayout : public QObject
} // ::qan

QML_DECLARE_TYPE(qan::OrgTreeLayout)