Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:coalton/benchmark deprecated/impendingly deprecated #1204

Open
Izaakwltn opened this issue Aug 9, 2024 · 1 comment
Open

:coalton/benchmark deprecated/impendingly deprecated #1204

Izaakwltn opened this issue Aug 9, 2024 · 1 comment
Assignees
Labels
bug Something isn't working bug? testing

Comments

@Izaakwltn
Copy link
Collaborator

The Coalton benchmark library depends on trivial-benchmark, which has recently (2 months ago) gone through a full rewrite.

Quicklisp is still loading a version of trivial-benchmark from October of last year, so until that updates there's no true break as long as you're using quicklisp. If you're manually adding dependencies locally however, this is already a breaking change.

The main changes are the removal of the macros define-benchmark-package and define-benchmark.

I'm planning on tackling this but wanted to open it to discussion.

I think this refactor would also be an opportunity to bolster our benchmark library, and make sure it is included in some facets of CI, at minimum making sure the benchmarks compile, and potentially running benchmarks on new branches, comparing to main.

@Izaakwltn Izaakwltn added bug Something isn't working bug? testing labels Aug 9, 2024
@Izaakwltn Izaakwltn self-assigned this Aug 9, 2024
@Izaakwltn
Copy link
Collaborator Author

Also, similarly to coalton/testing, I think it might be useful to have a coalton/benchmarking library for external coalton programs to have friendly benchmarking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bug? testing
Projects
None yet
Development

No branches or pull requests

1 participant