Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training errors due batching of oracle_actions #1

Open
mdelhoneux opened this issue May 25, 2020 · 0 comments
Open

Training errors due batching of oracle_actions #1

mdelhoneux opened this issue May 25, 2020 · 0 comments

Comments

@mdelhoneux
Copy link
Collaborator

There are errors when training lt_alknsis and fr_sequoia with a batch size of 8. I have not fully diagnosed the issue but I am quite confident that the problem comes from using the list of oracle actions from the metadata 'gold_actions' list instead of from a tensor as was done in the old code, see

oracle_actions = deepcopy([d['gold_actions'] for d in metadata])

This is because we pop from this list after an action is taken. In the majority of cases, this works fine, since we should only see a sentence once for every training iteration. However, there seems to be some weird things happening with allennlp where a sentence can be repeated in a batch (presumably to make sure the batch is full). This means that the second time that we see the sentence, the correct action that we should take has been popped from the list.
The easiest fix is probably to revert back to using tensors as gold actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant