Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@coasys/ad4m-executor: LanguageController/LANGUAGE_CONTROLLER Typescript Type issues #493

Open
btakita opened this issue Jun 9, 2024 · 0 comments

Comments

@btakita
Copy link

btakita commented Jun 9, 2024

globalThis.LANGUAGES is declared at https://github.com/coasys/ad4m/blob/dev/executor/src/languages_extension.d.ts#L38-L46

declare global {
    interface RustLanguages {
        perspectiveDiffReceived: (diff: PerspectiveDiff, languageAddress: string) => void;
        syncStateChanged: (state: PerspectiveState, languageAddress: string) => void;
        telepresenceSignalReceived: (signal: PerspectiveExpression, languageAddress: string) => void;
    }

    const LANGUAGES: RustLanguages;
}

But LANGUAGE_CONTROLLER is used at https://github.com/coasys/ad4m/blob/dev/executor/src/core/LanguageController.ts#L197-L216

There are other type errors when renaming this. Relating to @coasys/ad4m & @coasys/executor having different type definitions of:

  • LinkExpression
  • PerspectiveDiff
  • PerspectiveExpression
  • PerspectiveState
btakita added a commit to btakita/ad4m that referenced this issue Jun 9, 2024
btakita added a commit to btakita/ad4m that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant