-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache busting support #322
Comments
This sounds right, and supporting both options should be done. Some sites would opt for nothing, some for site timestamp, and some with bigger cache pressure might just want the per-asset cache buster. Probably a config option, |
I think both can be implemented with little problem. The site timestamp is the easiest to get implemented. An asset checksum might take more work. It can be done now but the performance hit might be a frustration. I can see the idea of having a flag for that. Moe ideally, I think is a refactoring I want to do. The idea is to re-architect inspired by ECS which would effectively make our data an "customized, in-memory database". That combined with some tweaks for Liquid would allow our checksumming to be lazy. One of the design problems I've been having with asset checksum and general page metadata is how to make it work. If I take "./css/theme.css" and turn it into We might say "just include the extension". So
Thoughts on a solution
|
could it become something like |
about the performance hit from an asset checksum, your problem is probably using the wrong hash algorithm. web assets don't need cryptographic hashes. i think the correct hash for this use case would be xxhash16. also, about the design conflict, i'd expect selecting files to work something like |
This is created from #254.
Options
site.bust_cache
variable that is a timestamp of when the program is runasset.<path>.bust_cache
variable that is checksum of the assetThe text was updated successfully, but these errors were encountered: