Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Readme links & version and liquid (5.0.0) render instead of include #454

Closed
elpiel opened this issue Jan 24, 2022 · 1 comment · Fixed by #455
Closed

Update Readme links & version and liquid (5.0.0) render instead of include #454

elpiel opened this issue Jan 24, 2022 · 1 comment · Fixed by #455

Comments

@elpiel
Copy link

elpiel commented Jan 24, 2022 •
edited
Loading

  1. The version mentioned in docs.rs & README is old (0.20) and the latest one is 0.23
  2. Readme links to filter.rs, include_tag.rs, comment_block do not work.
  3. The include tag is deprecated and render is not in the std :

The include tag is deprecated; please use render instead.
https://shopify.github.io/liquid/tags/template#include
@epage epage mentioned this issue Jan 24, 2022
Merged
@epage
Copy link
Member

epage commented Jan 24, 2022

Thanks for catching these! Forgot we made so many code references in the README.

As for include, that is covered by #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Update README epage/liquid-rust
2 participants
@epage @elpiel