Upgrade to testcontainers 0.15 #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikmckenz
commented
Feb 24, 2024
| @@ -89,7 +91,7 @@ pub struct Bitcoind<'c> { | |||
| impl<'c> Bitcoind<'c> { | |||
| /// Starts a new regtest bitcoind container | |||
| pub fn new(client: &'c clients::Cli) -> Result<Self> { | |||
| let container = client.run(BitcoinCore::default()); | |||
| let container = client.run(BitcoinCore); | |||
There was a problem hiding this comment.
This was a clippy suggestion, but is unrelated to the main PR. Can be reverted with no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Testcontainers 0.15 they moved the community images from the internal package to another package, and inside that separate package they unfortunately removed the Bitcoin Core image that this bitcoin-harness relies on: testcontainers/testcontainers-rs-modules-community#30
So I simply moved the image as was removed from the modules into this repo, and all the tests seem to pass.