Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Replace .format() with f-strings #19492

Merged
merged 1 commit into from
Oct 17, 2023
Merged

test: Replace .format() with f-strings #19492

merged 1 commit into from
Oct 17, 2023

Conversation

martinpitt
Copy link
Member

ruff 0.1 rightfully starts to complain about these. Done with ruff check --fix.

This "spontaneously" broke main, the tox test now fails on this.

@martinpitt
test: Replace .format() with f-strings
7b59fba 
ruff 0.1 rightfully starts to complain about these. Done with `ruff check --fix`.
@martinpitt martinpitt added the release-blocker Targetted for next release label Oct 17, 2023
@martinpitt martinpitt requested a review from jelly October 17, 2023 09:22
@martinpitt martinpitt merged commit 993eca0 into cockpit-project:main Oct 17, 2023
37 checks passed
@martinpitt martinpitt deleted the f-string branch October 17, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jelly jelly jelly approved these changes

Assignees
No one assigned
Labels
release-blocker Targetted for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinpitt @jelly