[ActiveRecord 5.2 Test Failure] test/cases/adapters/postgresql/collation_test.rb

[alimi]

All tests fail in the setup trying to set collate to C.

ActiveRecord::StatementInvalid: PG::SyntaxError: ERROR:  at or near ",": syntax error: invalid locale C: language: tag is not well-formed
DETAIL:  source SQL:
CREATE TABLE "postgresql_collations" ("id" bigserial primary key, "string_c" character varying COLLATE "C", "text_posix" text COLLATE "POSIX")

https://www.postgresql.org/docs/current/collation.html
https://www.cockroachlabs.com/docs/v19.2/collate.html

See the Contributing Guide for instructions on running tests.

If the test isn't valid against CockroachDB

1. Add a ruby file to test/excludes that matches the name of the test class if one doesn't already exist. For example to exclude a test from ActiveRecord::AdapterTest, create test/excludes/ActiveRecord/AdapterTest.rb.
2. Add an exclude statement to the file with the name of the test to exclude and a description. For example to exclude test_indexes from ActiveRecord::AdapterTest:
   

   activerecord-cockroachdb-adapter/test/excludes/ActiveRecord/AdapterTest.rb

   Line 1 in c3cb637

   exclude :test_indexes, "Rails transactional tests are being used while making schema changes. See https://www.cockroachlabs.com/docs/stable/online-schema-changes.html#limited-support-for-schema-changes-within-transactions."

3. Finally, if the test can run against CockroachDB with a few changes, add it to test/cases. Everything from the ActiveRecord test suite will be available, so a lot of the excluded test can be copied over. Namespace the test under the CockroachDB module to avoid name collisions. See test/cases/adapter_test.rb for an example.

See #48.