From 59b4dfd87c87d712cbcdad5efecb0f40cbf43d2f Mon Sep 17 00:00:00 2001 From: Nathan VanBenschoten Date: Mon, 19 Aug 2024 17:15:37 -0400 Subject: [PATCH] roachtest: fix pgjdbc XA test suite Informs #22329. This commit fixes the pgjdbc blocklist to reflect the current state of support for XA transactions in CockroachDB. With the newly added support for two-phase commit transactions, all tests in the XADataSourceTest test suite now pass except for `mappingOfConstraintViolations`, which is blocked by #31632 (DEFERRABLE foreign keys). Release note: None --- pkg/cmd/roachtest/tests/pgjdbc_blocklist.go | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/pkg/cmd/roachtest/tests/pgjdbc_blocklist.go b/pkg/cmd/roachtest/tests/pgjdbc_blocklist.go index f7d4c69d78ad..44764a9ea3a4 100644 --- a/pkg/cmd/roachtest/tests/pgjdbc_blocklist.go +++ b/pkg/cmd/roachtest/tests/pgjdbc_blocklist.go @@ -621,23 +621,7 @@ var pgjdbcBlockList = blocklist{ `org.postgresql.test.util.PasswordUtilTest.encryptionTypeValueOfOn()`: "73337", `org.postgresql.test.util.PasswordUtilTest.mD5()`: "73337", `org.postgresql.test.util.PasswordUtilTest.scramSha256()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.autoCommit()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.commitByDifferentConnection()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.commitUnknownXid()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.committingCommittedXid()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.databaseRemovesPreparedBeforeCommit()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.databaseRemovesPreparedBeforeRollback()`: "unknown", `org.postgresql.test.xa.XADataSourceTest.mappingOfConstraintViolations()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.networkIssueOnCommit()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.networkIssueOnRollback()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.onePhaseCommitOfPrepared()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.preparingPreparedXid()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.recover()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.repeatedRolledBack()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.rollback()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.rollbackByDifferentConnection()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.rollbackUnknownXid()`: "unknown", - `org.postgresql.test.xa.XADataSourceTest.twoPhaseCommit()`: "unknown", } var pgjdbcIgnoreList = blocklist{