Consider making kv.dist_sender.concurrency_limit cluster setting public in at least v24.3, possibly v24.1+

[rmloveland]

We are working on adding it to docs as a performance recommendation in some scenarios (see PR cockroachdb/docs#19096 for details)

via @sean- in discussion on the docs PR:

we decided to not backport the change per discussion in: #131535 (comment)

however, perhaps we would be willing to flip the setting to public on v24.1 and v24.2 even if we don't want to change the default

Jira issue: CRDB-44656

Epic CRDB-43580

[rmloveland]

update: we should also do kv.streamer.concurrency_limit since it's also mentioned in linked docs PR

[arulajmani]

@rmloveland, it turns out that these two settings take their default value from GOMAXPROCS, which is dependent on the machine they run on. This makes making the setting public hard, as the generated docs expect a constant value for public cluster settings.

[rmloveland]

it turns out that these two settings take their default value from GOMAXPROCS, which is dependent on the machine they run on. This makes making the setting public hard, as the generated docs expect a constant value for public cluster settings.

would it be enough to update the generated doc as follows to say "by default uses GOMAXPROCS" and flip it public? or are you saying there is something else that expects a hardcoded value?

...

ah ok i looked some more and see settings like kv.dist_sender.circuit_breaker.probe.timeout with stuff like 3*time.Second, etc

and we can't call GOMAXPROCS on the build machine b/c that is meaningless for the user's machine

i will close this for now, agree with your comment here that it doesn't feel worth it to do a bunch of work for this