Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/tests: TestRandomSyntaxGeneration failed [unexpected statement: *tree.RollbackPrepared] #137325

Closed
cockroach-teamcity opened this issue Dec 12, 2024 · 8 comments · Fixed by #129448
Closed

sql/tests: TestRandomSyntaxGeneration failed [unexpected statement: *tree.RollbackPrepared] #137325

cockroach-teamcity opened this issue Dec 12, 2024 · 8 comments · Fixed by #129448
Assignees
@spilchen
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Dec 12, 2024 •
edited by spilchen
Loading

sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 49cff91f3501494deaf038671bc643c194a0e3ca:

Random syntax error:

    rsg_test.go:964: Crash detected: server panic: pq: internal error: unexpected statement: *tree.RollbackPrepared

Query:

        ROLLBACK PREPARED 'string';
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Dec 12, 2024
@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 49cff91f3501494deaf038671bc643c194a0e3ca:

Random syntax error:

    rsg_test.go:964: Crash detected: server panic: pq: internal error: unexpected statement: *tree.RollbackPrepared

Query:

        ROLLBACK PREPARED 'string';
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity mentioned this issue Dec 14, 2024
Closed
@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ fe048f6e72edca59b4367463db1d0d00783f08ab:

Random syntax error:

    rsg_test.go:964: Crash detected: server panic: pq: internal error: unexpected statement: *tree.PrepareTransaction

Query:

        PREPARE TRANSACTION 'string';
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 9354770c7c6eb5a89437068d8c6a4accf8031b67:

Random syntax error:

    rsg_test.go:964: Crash detected: server panic: pq: internal error: unexpected statement: *tree.RollbackPrepared

Query:

        ROLLBACK PREPARED 'string';
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@spilchen spilchen changed the title sql/tests: TestRandomSyntaxGeneration failed sql/tests: TestRandomSyntaxGeneration failed [unexpected statement: *tree.RollbackPrepared] Dec 16, 2024
@spilchen
Copy link
Contributor

I think there are two separate problems logged in this issue:

  1. unexpected statement: *tree.RollbackPrepared
    I suspect this is related to the XA grammar that was just added, which includes 'ROLLBACK PREPARED` in sql: add parser support for XA transactions #129298.

  2. building declarative schema change targets for CONFIGURE ZONE: programming error: resolving table 131 does not give a PrimaryIndex element
    This needs a bit more investigation but could be related to the recent config zone changes in the DSC.

I'll keep this issue for the ROLLBACK PREPARED and create another issue to investigate the second problem.

@spilchen
Copy link
Contributor

Opened #137541 for the 2nd issue.

@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ a653b4e4e6483cec7d65808ba4d55d8c63747a6e:

Random syntax error:

    rsg_test.go:964: Crash detected: server panic: pq: internal error: unexpected statement: *tree.CommitPrepared

Query:

        COMMIT PREPARED 'string';
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@nvanbenschoten nvanbenschoten mentioned this issue Dec 17, 2024
Merged
@spilchen
Copy link
Contributor

This will get addressed once #129448 goes in.

@spilchen spilchen self-assigned this Dec 17, 2024
@exalate-issue-sync exalate-issue-sync bot added the P-1 Issues/test failures with a fix SLA of 1 month label Dec 17, 2024
@cockroach-teamcity
Copy link
Member Author

sql/tests.TestRandomSyntaxGeneration failed with artifacts on master @ 51693691ed763f700dd06fa2d001cce1ffd42203:

Random syntax error:

    rsg_test.go:964: Crash detected: server panic: pq: internal error: unexpected statement: *tree.PrepareTransaction

Query:

        PREPARE TRANSACTION 'string';
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@craig craig bot closed this as completed in 694ca19 Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spilchen spilchen

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. P-1 Issues/test failures with a fix SLA of 1 month release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: implement XA transaction SQL statements nvanbenschoten/cockroach
2 participants
@spilchen @cockroach-teamcity