sql: allow_role_memberships_to_change_during_transaction does not allow for creating or dropping roles #137710
Assignees
Labels
branch-master
Failures and bugs on the master branch.
branch-release-24.1
Used to mark GA and release blockers, technical advisories, and bugs for 24.1
branch-release-24.2
Used to mark GA and release blockers, technical advisories, and bugs for 24.2
branch-release-24.3
Used to mark GA and release blockers, technical advisories, and bugs for 24.3
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-support
Would prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docs
P-2
Issues/test failures with a fix SLA of 3 months
T-sql-foundations
SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Comments
Dedej-Bergin
added
C-bug
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Hi @Dedej-Bergin, please add branch-* labels to identify which branch(es) this C-bug affects. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
exalate-issue-sync
bot
added
P-2
rafiss
changed the title
rimadeodhar
added
branch-master
Dedej-Bergin
added a commit
to Dedej-Bergin/cockroach
that referenced
this issue
Jan 2, 2025
…ow for creating or dropping roles When we set `allow_role_memberships_to_change_during_transaction` we should be able to create and drop users even when there are contending transactions on the `system.users` and `system.role_options`. These code changes release the locks on those system tables when `allow_role_memberships_to_change_during_transaction` is set. Fixes: cockroachdb#137710 Release note (bug fix): When we set `allow_role_memberships_to_change_during_transaction` are able to create and drop users quickly even when there are contending transactions on the `system.users` and `system.role_options`.
Dedej-Bergin
added a commit
to Dedej-Bergin/cockroach
that referenced
this issue
Jan 8, 2025
…ow for creating or dropping roles When we set `allow_role_memberships_to_change_during_transaction` we should be able to create and drop users even when there are contending transactions on the `system.users` and `system.role_options`. These code changes release the locks on those system tables when `allow_role_memberships_to_change_during_transaction` is set. Fixes: cockroachdb#137710 Release note (bug fix): When we set `allow_role_memberships_to_change_during_transaction` are able to create and drop users quickly even when there are contending transactions on the `system.users` and `system.role_options`.
Dedej-Bergin
added a commit
to Dedej-Bergin/cockroach
that referenced
this issue
Jan 9, 2025
…ow for creating or dropping roles When we set `allow_role_memberships_to_change_during_transaction` we should be able to create and drop users even when there are contending transactions on the `system.users` and `system.role_options`. These code changes release the locks on those system tables when `allow_role_memberships_to_change_during_transaction` is set. Fixes: cockroachdb#137710 Release note (bug fix): When we set `allow_role_memberships_to_change_during_transaction` are able to create and drop users quickly even when there are contending transactions on the `system.users` and `system.role_options`.
craig bot
pushed a commit
that referenced
this issue
Jan 10, 2025
137940: sql: allow creating or dropping roles while membership cache is being used r=Dedej-Bergin a=Dedej-Bergin When we set `allow_role_memberships_to_change_during_transaction` we should be able to create and drop users even when there are contending transactions on the `system.users` and `system.role_options`. These code changes release the locks on those system tables when `allow_role_memberships_to_change_during_transaction` is set. Fixes: #137710 Release note (bug fix): When we set `allow_role_memberships_to_change_during_transaction` are able to create and drop users quickly even when there are contending transactions on the `system.users` and `system.role_options`. 138673: changefeedccl: correct doc and rename changefeed.min_highwater_advance r=asg0451 a=andyyang890 Epic: CRDB-37337 Release note (ops change): The `changefeed.min_highwater_advance` cluster setting has been renamed to `changefeed.resolved_timestamp.min_update_interval` to more accurately reflect its function. Its description has also been updated. The old name remains usable for backwards-compatibility. 138826: crosscluster: deflake TestStreamIngestionJobWithRandomClient r=jeffswenson a=jeffswenson TestStreamIngestionJobWithRandomClient is flaking under stress with the following errors: ``` pq: cutover time 1736520389.999999000,0 is before earliest safe cutover time 1736520390.771027375,0 ``` ``` "0" is not greater than "0" ``` The first error occurs because the frontier would sometimes include a time that is earlier than the PTS created for the replication job. The second error would occur if a cutover time was picked that is earlier than any data written to the cluster. The test now uses a different strategy for picking a cutover time. The test ensures the cutover time is after the retained time and at least one checkpoint. Release note: none Epic: [CRDB-40896](https://cockroachlabs.atlassian.net/browse/CRDB-40896) Co-authored-by: Bergin Dedej <[email protected]> Co-authored-by: Andy Yang <[email protected]> Co-authored-by: Jeff Swenson <[email protected]>
Dedej-Bergin
added a commit
to Dedej-Bergin/cockroach
that referenced
this issue
Jan 14, 2025
… used When we set `allow_role_memberships_to_change_during_transaction` we should be able to create and drop users even when there are contending transactions on the `system.users` and `system.role_options`. These code changes release the locks on those system tables when `allow_role_memberships_to_change_during_transaction` is set. Fixes: cockroachdb#137710 Release note (bug fix): When we set `allow_role_memberships_to_change_during_transaction` are able to create and drop users quickly even when there are contending transactions on the `system.users` and `system.role_options`.
Dedej-Bergin
added a commit
to Dedej-Bergin/cockroach
that referenced
this issue
Jan 14, 2025
… used When we set `allow_role_memberships_to_change_during_transaction` we should be able to create and drop users even when there are contending transactions on the `system.users` and `system.role_options`. These code changes release the locks on those system tables when `allow_role_memberships_to_change_during_transaction` is set. Fixes: cockroachdb#137710 Release note (bug fix): When we set `allow_role_memberships_to_change_during_transaction` are able to create and drop users quickly even when there are contending transactions on the `system.users` and `system.role_options`.
Dedej-Bergin
added a commit
to Dedej-Bergin/cockroach
that referenced
this issue
Jan 14, 2025
… used When we set `allow_role_memberships_to_change_during_transaction` we should be able to create and drop users even when there are contending transactions on the `system.users` and `system.role_options`. These code changes release the locks on those system tables when `allow_role_memberships_to_change_during_transaction` is set. Fixes: cockroachdb#137710 Release note (bug fix): When we set `allow_role_memberships_to_change_during_transaction` are able to create and drop users quickly even when there are contending transactions on the `system.users` and `system.role_options`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
When we set
allow_role_memberships_to_change_during_transactionwe should beable to create and drop users even when there are contending transactions on the
system.usersandsystem.role_options. These code changes release the locks onthose system tables when
allow_role_memberships_to_change_during_transactionis set.This issue was originally found in this internal support issue: https://github.com/cockroachlabs/support/issues/3098
Jira issue: CRDB-45713
The text was updated successfully, but these errors were encountered: