UI: statement bundle silently fails when min_execution_latency is null #139340
Assignees
Labels
branch-master
Failures and bugs on the master branch.
branch-release-24.3
Used to mark GA and release blockers, technical advisories, and bugs for 24.3
branch-release-25.1
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
O-testcluster
Issues found or occurred on a test cluster, i.e. a long-running internal cluster
T-observability
Comments
kyle-a-wong
added
branch-master
kyle-a-wong
added a commit
to kyle-a-wong/cockroach
that referenced
this issue
Jan 17, 2025
A bug in db console was resulting in statement diagnostics reports to not work as intended. As a result, activating diagnostics didn't result in the intended state change which showed a user that a diagnostics report is running or downloadble. This was happening in edge cases where reports "minExecutionLatency" response field was null, but the db console expected it to be populated. Now, db console should handle this edge case. Fixes: cockroachdb#139340 Epic: none Release note (bug fix): Fixes a bug where sometimes activating diagnostics for sql activity appears unresponsive, with no state or status update upon activating. Now, the status should always reflect that diagnosticsa are active or that a statement bundle is downloadable.
kyle-a-wong
added a commit
to kyle-a-wong/cockroach
that referenced
this issue
Jan 17, 2025
A bug in db console was resulting in statement diagnostics reports to not work as intended. As a result, activating diagnostics didn't result in the intended state change which showed a user that a diagnostics report is running or downloadble. This was happening in edge cases where reports "minExecutionLatency" response field was null, but the db console expected it to be populated. Now, db console should handle this edge case. This commit also adds nanosecond granularity to the returned StatementDiagnosticsResponse.min_execution_latency field. Previously only the seconds portion of the statement's min_execution_latency was converted into the returned objects duration, but often times this latency will be sub 1 second, resulting in "O" to be returned. Fixes: cockroachdb#139340 Epic: none Release note (bug fix): Fixes a bug where sometimes activating diagnostics for sql activity appears unresponsive, with no state or status update upon activating. Now, the status should always reflect that diagnosticsa are active or that a statement bundle is downloadable.
kyle-a-wong
added a commit
to kyle-a-wong/cockroach
that referenced
this issue
Jan 21, 2025
A bug in db console was resulting in statement diagnostics reports to not work as intended. As a result, activating diagnostics didn't result in the intended state change which showed a user that a diagnostics report is running or downloadble. This was happening in edge cases where reports "minExecutionLatency" response field was null, but the db console expected it to be populated. Now, db console should handle this edge case. This commit also adds nanosecond granularity to the returned StatementDiagnosticsResponse.min_execution_latency field. Previously only the seconds portion of the statement's min_execution_latency was converted into the returned objects duration, but often times this latency will be sub 1 second, resulting in "O" to be returned. Fixes: cockroachdb#139340 Epic: none Release note (bug fix): Fixes a bug where sometimes activating diagnostics for sql activity appears unresponsive, with no state or status update upon activating. Now, the status should always reflect that diagnosticsa are active or that a statement bundle is downloadable.
nameisbhaskar
added
the
O-testcluster
craig bot
pushed a commit
that referenced
this issue
Jan 22, 2025
139342: ui: fix statement diag reports when min exec latency is null r=kyle-a-wong a=kyle-a-wong A bug in db console was resulting in statement diagnostics reports to not work as intended. As a result, activating diagnostics didn't result in the intended state change which showed a user that a diagnostics report is running or downloadble. This was happening in edge cases where reports "minExecutionLatency" response field was null, but the db console expected it to be populated. Now, db console should handle this edge case. Fixes: #139340 Epic: none Release note (bug fix): Fixes a bug where sometimes activating diagnostics for sql activity appears unresponsive, with no state or status update upon activating. Now, the status should always reflect that diagnosticsa are active or that a statement bundle is downloadable. 139487: crosscluster/logical: permanent job errors should fail LDR job r=kev-cao a=msbutler Previously, permanent job errors would pause the LDR job, like PCR. Since LDR doesn't have a cutover step, we should instead fail the job to provide a clearer UX to the user. Epic: none Release note: none 139491: crosscluster/physical: wait for sip shutdown before cutover r=kev-cao a=msbutler Informs #136588 Release note: none Co-authored-by: Kyle Wong <[email protected]> Co-authored-by: Michael Butler <[email protected]>
craig bot
pushed a commit
that referenced
this issue
Jan 22, 2025
139342: ui: fix statement diag reports when min exec latency is null r=kyle-a-wong a=kyle-a-wong A bug in db console was resulting in statement diagnostics reports to not work as intended. As a result, activating diagnostics didn't result in the intended state change which showed a user that a diagnostics report is running or downloadble. This was happening in edge cases where reports "minExecutionLatency" response field was null, but the db console expected it to be populated. Now, db console should handle this edge case. Fixes: #139340 Epic: none Release note (bug fix): Fixes a bug where sometimes activating diagnostics for sql activity appears unresponsive, with no state or status update upon activating. Now, the status should always reflect that diagnosticsa are active or that a statement bundle is downloadable. 139491: crosscluster/physical: wait for sip shutdown before cutover r=kev-cao a=msbutler Informs #136588 Release note: none Co-authored-by: Kyle Wong <[email protected]> Co-authored-by: Michael Butler <[email protected]>
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Based on the specified backports for linked PR #139342, I applied the following new label(s) to this issue: branch-release-24.3, branch-release-25.1. Please adjust the labels as needed to match the branches actually affected by this issue, including adding any known older branches. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
blathers-crl
bot
added
branch-release-24.3
blathers-crl bot
pushed a commit
that referenced
this issue
Jan 22, 2025
A bug in db console was resulting in statement diagnostics reports to not work as intended. As a result, activating diagnostics didn't result in the intended state change which showed a user that a diagnostics report is running or downloadble. This was happening in edge cases where reports "minExecutionLatency" response field was null, but the db console expected it to be populated. Now, db console should handle this edge case. This commit also adds nanosecond granularity to the returned StatementDiagnosticsResponse.min_execution_latency field. Previously only the seconds portion of the statement's min_execution_latency was converted into the returned objects duration, but often times this latency will be sub 1 second, resulting in "O" to be returned. Fixes: #139340 Epic: none Release note (bug fix): Fixes a bug where sometimes activating diagnostics for sql activity appears unresponsive, with no state or status update upon activating. Now, the status should always reflect that diagnosticsa are active or that a statement bundle is downloadable.
blathers-crl bot
pushed a commit
that referenced
this issue
Jan 22, 2025
A bug in db console was resulting in statement diagnostics reports to not work as intended. As a result, activating diagnostics didn't result in the intended state change which showed a user that a diagnostics report is running or downloadble. This was happening in edge cases where reports "minExecutionLatency" response field was null, but the db console expected it to be populated. Now, db console should handle this edge case. This commit also adds nanosecond granularity to the returned StatementDiagnosticsResponse.min_execution_latency field. Previously only the seconds portion of the statement's min_execution_latency was converted into the returned objects duration, but often times this latency will be sub 1 second, resulting in "O" to be returned. Fixes: #139340 Epic: none Release note (bug fix): Fixes a bug where sometimes activating diagnostics for sql activity appears unresponsive, with no state or status update upon activating. Now, the status should always reflect that diagnosticsa are active or that a statement bundle is downloadable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the response from
_status/stmtdiagreportsreturns undefined for thereport.minExecutionLatencyfield, db console silently errors, resulting in the inability to download statement bundles. This results in a UX where it looks like nothing is happening when diagnostics are activated.Screen.Recording.2025-01-17.at.9.31.14.AM.mov
Jira issue: CRDB-46610
The text was updated successfully, but these errors were encountered: