feat: autodetect an ADB device when no vendor or product ID is specified #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Changes - Added methods `autodetect` to `autodetect_with_custom_private_key` to `ADBUSBDevice` - Added private functions to check if a usb device has the signature of an ADB device - Made the `vendor_id` and `product_id` USB arguments optional and default to aforementioned methods
cocool97
requested changes
Oct 30, 2024
|
I will make the necessary changes in a day's worth of time. Thanks again for the review :D
|
|
I cleaned the code a bit with functions that could be called either with a custom private key or not. I also remove the thread(s) spawned to get devices, if no device is find at the time an error is raised |
|
Thank you very much! I like that you are explicitly refusing to handle multiple devices under autodetect. Makes sense.
Should we expose the search_adb_devices function or something similar that allows the user to query all matching VIDs and PIDs?
|
|
I think we can keep it private for now and see if there are people needing it |
|
good call
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
autodetecttoautodetect_with_custom_private_keytoADBUSBDevicevendor_idandproduct_idUSB arguments optional and default to aforementioned methods