webgpu update #16184
Merged
webgpu update #16184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check ReportThis pull request does not change any public interfaces ! |
star-e
reviewed
Sep 5, 2023
| @@ -54,7 +54,7 @@ void CCWGPUBuffer::doInit(const BufferInfo &info) { | |||
| _gpuBufferObject->indirectObjs.resize(drawInfoCount); | |||
| } | |||
|
|
|||
| _size = ceil(info.size / 4.0) * 4; | |||
| _size = ceil(info.size / 16.0) * 16; | |||
There was a problem hiding this comment.
Consider using boost::alignment::align_up or (size + (n - 1)) / n * n to avoid double conversion, which might introduce precision problem.
star-e
reviewed
Sep 5, 2023
| @@ -446,7 +437,7 @@ void CCWGPUCommandBuffer::bindStates() { | |||
| if (indexBuffer) { | |||
| wgpuRenderPassEncoderSetIndexBuffer(_gpuCommandBufferObj->wgpuRenderPassEncoder, | |||
| indexBuffer->gpuBufferObject()->wgpuBuffer, | |||
| indexBuffer->getStride() == 2 ? WGPUIndexFormat::WGPUIndexFormat_Uint16 : WGPUIndexFormat_Uint32, | |||
| indexBuffer->getStride() <= 2 ? WGPUIndexFormat::WGPUIndexFormat_Uint16 : WGPUIndexFormat_Uint32, | |||
There was a problem hiding this comment.
We might assert(indexBuffer->getStride() >= 2). I am not sure whether we can handle stride < 2.
There was a problem hiding this comment.
OK, I think I must have met uint8 array as an index buffer, shall we make all index buffer a u16array or a u32array?
There was a problem hiding this comment.
Yes. We can only use u16array or u32array, if it is possible.
star-e
approved these changes
Sep 5, 2023
6 tasks
dumganhar
reviewed
Sep 8, 2023
dumganhar
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: # cocos/cocos-engine-external#417
Changelog
webgpu update:
Continuous Integration
This pull request:
Compatibility Check
This pull request: