Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller spine library, save 14KB package size #17731

Merged
merged 10 commits into from
Oct 23, 2024
Merged

Smaller spine library, save 14KB package size #17731

merged 10 commits into from
Oct 23, 2024

Conversation

dumganhar
Copy link
Contributor

Re: #17715

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

👍 Package size ⤵ -14901 bytes, old: 5445998, new: 5431097

Interface Check Report

This pull request does not change any public interfaces !

minggo
minggo reviewed Oct 17, 2024
View reviewed changes
cocos/spine/lib/spine-define.ts
property: 'str',
getter: prototype.str,
},
['length', prototype.length],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can change object to array?

Copy link
Contributor Author

@dumganhar dumganhar Oct 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For smaller code. You could compare the code, and using array will make the code cleaner.

@dumganhar dumganhar marked this pull request as draft October 17, 2024 03:47
@dumganhar dumganhar force-pushed the 385-smaller-spine-define branch from 403dc0c to fb62f21 Compare October 22, 2024 02:47
@dumganhar dumganhar marked this pull request as ready for review October 22, 2024 02:48
@dumganhar dumganhar changed the title Smaller spine-define.ts, save 8KB package size Smaller spine-define.ts, save 10KB package size Oct 22, 2024
@dumganhar dumganhar changed the title Smaller spine-define.ts, save 10KB package size Smaller spine library, save 10KB package size Oct 22, 2024
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

2 similar comments
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@dumganhar dumganhar marked this pull request as draft October 22, 2024 09:34
@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@dumganhar dumganhar changed the title Smaller spine library, save 10KB package size Smaller spine library, save 14KB package size Oct 23, 2024
@dumganhar
Copy link
Contributor Author

Windows PR test result:
https://cctest.cocos.org/#/reportview/PR-TEST/a4680461-8e51-496e-a0e7-a35e962240a3/-1~undefined

@dumganhar
Copy link
Contributor Author

@cocos-robot run test cases

@dumganhar dumganhar marked this pull request as ready for review October 23, 2024 08:53
@dumganhar dumganhar merged commit 9073fd3 into cocos:v3.8.5 Oct 23, 2024
26 checks passed
@github-actions GitHub Actions
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL
ios PASS PASS FAIL
mac PASS PASS PASS

@github-actions GitHub Actions
Copy link

@dumganhar, Please check the result of run test cases:

Task Details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bofeng-song bofeng-song Awaiting requested review from bofeng-song

@minggo minggo Awaiting requested review from minggo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dumganhar @minggo @bofeng-song