Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks in Spine caused by not calling freeStoreMemory. #18018

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

bofeng-song
Copy link
Contributor

@bofeng-song bofeng-song commented Dec 10, 2024

Re: #
https://github.com/cocos/3d-tasks/issues/18640

Changelog


Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

Copy link

github-actions bot commented Dec 10, 2024

⚠️ Package size ⤴ 74 bytes, old: 5441528, new: 5441602

Interface Check Report

! WARNING this pull request has changed these public interfaces:

@@ -52719,9 +52719,10 @@
             }
             export class wasmUtil {
                 static spineWasmInit(): void;
                 static spineWasmDestroy(): void;
-                static queryStoreMemory(size: number): number;
+                static freeStoreMemory(): void;
+                static createStoreMemory(size: number): number;
                 static querySpineSkeletonDataByUUID(uuid: string): SkeletonData;
                 static createSpineSkeletonDataWithJson(jsonStr: string, atlasText: string): SkeletonData;
                 static createSpineSkeletonDataWithBinary(byteSize: number, atlasText: string): SkeletonData;
                 static registerSpineSkeletonDataWithUUID(data: SkeletonData, uuid: string);

s_mem = new uint8_t[size];
s_memSize = size;
}
s_mem = new uint8_t[size];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't have to delete previous memory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

queryStoreMemory is responsible for allocation, while freeStoreMemory is responsible for deallocation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, why not rename to createStoreMemory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@minggo minggo merged commit 63f8fd9 into cocos:v3.8.6 Dec 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants