-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leaks in Spine caused by not calling freeStoreMemory. #18018
Conversation
|
s_mem = new uint8_t[size]; | ||
s_memSize = size; | ||
} | ||
s_mem = new uint8_t[size]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't have to delete previous memory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
queryStoreMemory is responsible for allocation, while freeStoreMemory is responsible for deallocation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, why not rename to createStoreMemory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Re: #
https://github.com/cocos/3d-tasks/issues/18640
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: