Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget support is missing #132

Open
TankTheFrank opened this issue Dec 11, 2017 · 5 comments
Open

Widget support is missing #132

TankTheFrank opened this issue Dec 11, 2017 · 5 comments

Comments

@TankTheFrank
Copy link

The readme says that widget is supported with AlignOnce but there is no widget component support whatsoever.

I don't know if it ended in the readme without being added at all or was lost along the way, in any case I'll open a pull request once I finish implementing basic widget AlignOnce for my own project.

Without any alignment the fixed width/fixed height mode cannot work making the whole project fairly pointless.

@minggo
Copy link
Contributor

minggo commented Dec 12, 2017

It already support AlignOnce. The coordinate output by Creator already do the alignment.

@TankTheFrank
Copy link
Author

AlignOnce doesn't exist in this plugin. How can it be supported if it's missing? Whatever you mean by "AlignOnce" is not what it is in Cocos Creator. Here is the tooltip with what AlignOnce means in case you missed it.

Just in case is too long to read, skip to the at runtime part.

align_once

Anyway, I've implemented it for my own use so do whatever you want with the "official" branch.

@minggo
Copy link
Contributor

minggo commented Dec 13, 2017

You are free to send a PR to support it, but i don't quite understand the issue. Could you please show me the wrong effect? It is better if there is a Creator project to reproduce it.

Thanks.

@jusforfun
Copy link

Hi, I've also encountered widget alignment issues when i exported out my project,
my ui elements that is using widget for alignment based on pinned %/px will still end up getting crop out on different aspect ratio devices; Running Cocos simulator will show that its aligned but not after exported out;

After digging into the parser scripts; I do not see the support of cc.widget component anywhere; There wasn't any remote parsing of widget data anywhere;

I do believe what @TankTheFrank says is true that widget alignment is still not supported;

@drelaptop
Copy link
Contributor

@tankorsmash @jusforfun I add a PR for the Widget support, see #160 , I will appreciate it if you would like to review and have a test.

Due to the Creator Widget Component is quite different from Cocos2d-x Widget class, So the support can't be perfect, please read that comments in PR firstly before you review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants