Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warden Auth #1431

Closed
23 of 25 tasks
captainmangoC4 opened this issue Apr 12, 2022 · 5 comments · Fixed by #1186
Closed
23 of 25 tasks

Warden Auth #1431

captainmangoC4 opened this issue Apr 12, 2022 · 5 comments · Fixed by #1186
Assignees
Labels
[EPIC] warden reg Warden Registration efficiency roadmap related to a key objective on our site roadmap UX/UI Issue will need some Ux attention in addition to dev WIP

Comments

@captainmangoC4
Copy link
Collaborator

captainmangoC4 commented Apr 12, 2022

@captainmangoC4 captainmangoC4 linked a pull request Apr 12, 2022 that will close this issue
@tealtigrrr tealtigrrr added roadmap related to a key objective on our site roadmap UX/UI Issue will need some Ux attention in addition to dev labels Apr 25, 2022
@Simon-Busch Simon-Busch added WIP [EPIC] warden reg Warden Registration efficiency labels May 26, 2022
@captainmangoC4
Copy link
Collaborator Author

captainmangoC4 commented May 26, 2022

For the pages that require auth (submit findings and register team), if the user is not logged in, show a message telling them to login. Message should be styled to look like the submit finding success message.


For submit findings, it should say something like:

Please log in

You need to be a registered warden currently connected via wallet to see this page.

Note to existing wardens:
As of [date] wardens are required to authenticate with a wallet to submit findings.

You can read more about this change here[link].

[connect with MetaMask] [connect with WalletConnect]


For team registration page, it should say:

Please log in

You need to be a registered warden, currently connected via wallet to register a team.

[connect with MetaMask] [connect with WalletConnect]

@Simon-Busch
Copy link
Contributor

Simon-Busch commented May 30, 2022

For the pages that require auth (submit findings and register team), if the user is not logged in, show a message telling them to login. Message should be styled to look like the submit finding success message.

For submit findings, it should say something like:

Please log in

You need to be a registered warden currently connected via wallet to see this page.

Note to existing wardens: As of [date] wardens are required to authenticate with a wallet to submit findings.

You can read more about this change here[link].

[connect with MetaMask] [connect with WalletConnect]

For team registration page, it should say:

Please log in

You need to be a registered warden, currently connected via wallet to register a team.

[connect with MetaMask] [connect with WalletConnect]

Done in issue #2046 :-)

Ready for your review

@adamavenir
Copy link
Contributor

I suggest considering #2100 as part of this effort in order to clean up repo activity and better manage permissions.

git submodules are pretty easy to implement if you're not familiar, and I'm happy to help.

@Simon-Busch
Copy link
Contributor

Simon-Busch commented Jun 7, 2022

I suggest considering #2100 as part of this effort in order to clean up repo activity and better manage permissions.

git submodules are pretty easy to implement if you're not familiar, and I'm happy to help.

I am not familiar with it, I definitely would like to do it 👍🏼 Will be discussed on Dev sync :)

@tealtigrrr
Copy link

I suggest considering #2100 as part of this effort in order to clean up repo activity and better manage permissions.

git submodules are pretty easy to implement if you're not familiar, and I'm happy to help.

Hey @sockdrawermoney we discussed this in our sync and agreed that while it would be good to use the submodule solution in the future, it adds a little too much complexity to implement it before we launch v1 of Warden Auth (since we are eager to get it out the door).

We are thinking that we can tackle this as part of our first post-launch set of fixes/enhancements for the auth/registration process.

Since the vast majority of registrations in the first few weeks will likely be re-registrations, I think we'll be able to avoid some of the awkward situations this approach solves for.

@sockdrawermoney You ok with us pushing this (#2100) until after launch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[EPIC] warden reg Warden Registration efficiency roadmap related to a key objective on our site roadmap UX/UI Issue will need some Ux attention in addition to dev WIP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants