Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Low pri] I get the animation error message even if I don't press the download animation button #487

Open
poorvasingal opened this issue Nov 27, 2018 · 5 comments
Milestone

Comments

@poorvasingal
Copy link

image

Low pri b/c it requires me to be on the share dialog for 30 seconds. The reason the animation didn't work is because I didn't hit the "Run" button. (In the future, may be better to just remove the download animation button altogether if the project hasn't been run).

@Erin007
Copy link
Contributor

Erin007 commented Nov 28, 2018

I think fixing #517 will also resolve this issue, because if we stop the 403 errors that are occurring even before the download animation button is clicked, we'll never show the "sorry, we were unable to download..." message regardless of how long the dialog is open. @Hamms does that sound correct to you?

@poorvasingal
Copy link
Author

Oooh, are we planning on making the fix so we don't do the call until we hit the Download animation button? I think that's great. And yeah, that should solve this error.

@Hamms
Copy link
Contributor

Hamms commented Nov 29, 2018

#517 is unrelated; we definitely want to start checking for the video before clicking the download button. We just need to update when the DownloadReplayVideo component calls its onError method to only do so if the button has been clicked

@Erin007
Copy link
Contributor

Erin007 commented Nov 29, 2018

@simplycloud
Copy link
Contributor

moving to post-HOC in case there is further work we want to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants