-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standard linting for vscode #201
Comments
@hkirat We'll update .editorconfig` and ESLint setup in VSCode to fix the linting issues. This will keep everyone's code consistent. what do u think |
@hkirat it might because of prettier and eslint conflicting with each other ref=https://stackoverflow.com/questions/61350494/eslint-rule-conflicts-with-prettier-rule |
should be fixible with eslint extending prettier config |
Ideally, the pre-commit hook should have not allowed the commit to go through if the linting failed for #199 The first checkpoint can be to fix the pre-commit hook. And if that does not solve the issue, we can extend / update ESLint setup. |
Lot of people are having big lint diffs while contributing
I'm assuming its because vscode (or whatever ide being used) is linting it a way that our project doesnt expect
For example - #199 (review)
Need a way so that auto lints in vscode follow the pattern expected
The text was updated successfully, but these errors were encountered: