Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard linting for vscode #201

Closed
hkirat opened this issue Mar 11, 2024 · 5 comments
Closed

Add standard linting for vscode #201

hkirat opened this issue Mar 11, 2024 · 5 comments

Comments

@hkirat
Copy link
Contributor

hkirat commented Mar 11, 2024

Lot of people are having big lint diffs while contributing
I'm assuming its because vscode (or whatever ide being used) is linting it a way that our project doesnt expect
For example - #199 (review)
Need a way so that auto lints in vscode follow the pattern expected

@TanmayDhobale
Copy link
Contributor

@hkirat We'll update .editorconfig` and ESLint setup in VSCode to fix the linting issues. This will keep everyone's code consistent. what do u think

@devsargam
Copy link
Collaborator

devsargam commented Mar 11, 2024

@hkirat it might because of prettier and eslint conflicting with each other

ref=https://stackoverflow.com/questions/61350494/eslint-rule-conflicts-with-prettier-rule

@devsargam
Copy link
Collaborator

should be fixible with eslint extending prettier config

@aadeshkulkarni
Copy link

Ideally, the pre-commit hook should have not allowed the commit to go through if the linting failed for #199

The first checkpoint can be to fix the pre-commit hook. And if that does not solve the issue, we can extend / update ESLint setup.

@TanmayDhobale
Copy link
Contributor

@hkirat can u check this pls #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants