Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The cohort 2.0 and cohort 3.0 filter is bugged #590

Closed
HarshK200 opened this issue Aug 27, 2024 · 5 comments · May be fixed by #599
Closed

bug: The cohort 2.0 and cohort 3.0 filter is bugged #590

HarshK200 opened this issue Aug 27, 2024 · 5 comments · May be fixed by #599
Labels
bug Something isn't working needs-triage

Comments

@HarshK200
Copy link

Describe the bug
bug: The cohort 2.0 and cohort 3.0 filter is bugged

To Reproduce
Steps to reproduce the behavior:

  1. Click on Cohort 2.0 filter
  2. Click back on cohort 3.0 filter it no longer works (probable some state issue onclick problem?)

Expected behavior
On clicking the filter buttons the content should filter as cohort 2 notes and cohort 3 note

Screenshots or GIFs

2024-08-27.21-05-29.mp4

Info (please complete the following information):

  • Browser : chrome
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@HarshK200 HarshK200 added bug Something isn't working needs-triage labels Aug 27, 2024
@Ashutoshpadhi629 Ashutoshpadhi629 mentioned this issue Aug 27, 2024
2 tasks
@Mahesh-1919
Copy link

May I work on this issue , could you assign it to me

@Gurveer1510
Copy link

I tried to fix it, first I thought the state switching of the buttons could be wrong, then I made some logs that what data is database sending to filter out AND the field "cohort" which should have 2 or 3 has 0 in all entries idk if its only the case with seeding data or something else.
But when I update the Track table and made some records have "cohort" 2 or 3 then the filtering was working fine.

image
the cohort field is set by default to 0

So,
image
this check will always give empty object.

image
when made changes in the database.

or am I missing something.

@Ashutoshpadhi629
Copy link
Contributor

@Gurveer1510 , in production the value is not zero , the fix here is to add the logic to change the state of both the buttons . i already fixed it in #588

              setCohort3(!cohort3);
              cohort2 && setCohort2(!cohort2);

@Gurveer1510
Copy link

@Gurveer1510 , in production the value is not zero , the fix here is to add the logic to change the state of both the buttons . i already fixed it in #588

              setCohort3(!cohort3);
              cohort2 && setCohort2(!cohort2);

Ohh, I fixed the state change bug too
image

but I thought it was something big. 😂

This was referenced Aug 28, 2024
@HarshK200
Copy link
Author

HarshK200 commented Aug 31, 2024

The main branch was reverted so no issue anymore?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@Ashutoshpadhi629 @Mahesh-1919 @HarshK200 @Gurveer1510 and others