Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Improvement: code pattern #586

Open
2 tasks done
yshplsngh opened this issue Nov 12, 2024 · 0 comments
Open
2 tasks done

✨ Improvement: code pattern #586

yshplsngh opened this issue Nov 12, 2024 · 0 comments

Comments

@yshplsngh
Copy link

πŸ“œ Description

I was going through the codebase and found this pattern, is there any purpose of this. If not, we can replace it with simple false?

πŸ‘Ÿ Reproduction steps

  1. Go /job-board/src/app/(auth)/verify-email/[token]/EmailVerificationLinkExpired.tsx
  2. refer finally in below function
  3. setIsLoading(!true) instead of setIsLoading(false);

const handleResendClick = async () => { setIsLoading(true); try { await verifyEmail({ token, resend: true }); setIsEmailSent(true); } catch { toast({ variant: 'destructive', title: 'Something went wrong, please try again!', }); } finally { setIsLoading(!true); } };

πŸ‘ Expected behavior

No response

πŸ“ƒ Provide any additional context for the Bug.

No response

πŸ‘€ Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏒 Have you read the Contributing Guidelines?

@yshplsngh yshplsngh changed the title ✨ Improvement: ✨ Improvement: code pattern Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant