Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to forms list after saving a new form draft or publishing a new form #337

Closed
aniri opened this issue Jan 16, 2021 · 16 comments · Fixed by #353
Closed

Redirect to forms list after saving a new form draft or publishing a new form #337

aniri opened this issue Jan 16, 2021 · 16 comments · Fixed by #353

Comments

@aniri
Copy link
Member

aniri commented Jan 16, 2021

Go to /forms
Fill in some data
Click the button for saving a draft form / publishing the form
After a successful result from the save action, redirect to the forms list

@Botosio
Copy link
Contributor

Botosio commented Oct 19, 2021

I can take a look at this.

@Botosio
Copy link
Contributor

Botosio commented Oct 19, 2021

@aniri for the QA setup, can I use a temporary username and password? I'm trying to just run locally.

@aniri
Copy link
Member Author

aniri commented Oct 19, 2021

@aniri for the QA setup, can I use a temporary username and password? I'm trying to just run locally.

hey @Botosio and welcome back! 🥳

you can use the test account:

{
  "user": "test",
  "password": "test2021"
}

@Botosio
Copy link
Contributor

Botosio commented Oct 19, 2021

@aniri ha, thanks I didn't know if you would remember or not. I'm running late on my Hactoberfest this year. Trying to pick up a couple of stories. Hope everything is going well.

@aniri
Copy link
Member Author

aniri commented Oct 19, 2021

@Botosio Yep, I remember :D And I'm good, I hope you are too!

I'm running late on my Hactoberfest this year.

Uh, oh! After we used the app in december last year, I added some issues for small improvements ;)

@aniri
Copy link
Member Author

aniri commented Oct 20, 2021

Btw, we used this app a bit after the last hacktoberfest and it was a huge improvement from it's previous version :D It's a lot more user friendly now and the feedback was great :D A huge thanks for all your help! 🤗

@Botosio
Copy link
Contributor

Botosio commented Oct 22, 2021

@aniri so I have this working and you get redirected back to the list, however some other process is killing the app...
I'm still looking into it but after a save and I see the Post API call, the application becomes non-responsive.

Does this happen to you?

@Botosio
Copy link
Contributor

Botosio commented Oct 23, 2021

@aniri Can we create an issue about after you submit on the forms page (publish or draft) the application hangs and then crashes. This is now blocking this PR.

@jrstrayhorn can confirm, happens on his local also.

@aniri
Copy link
Member Author

aniri commented Oct 23, 2021

hey @Botosio the same happens for me :( I will open the issue. I'll keep this PR open until the crash is also fixed in another PR, but the redirect part looks good 🚀

@Botosio
Copy link
Contributor

Botosio commented Oct 25, 2021

I'm getting a 400 post error now, I saw a PR that might have fixed it and wanted to test but no luck.
@aniri

@idormenco
Copy link
Member

@Botosio make sure that you use unique form code when creating a form. Unique to previously created forms

@Botosio
Copy link
Contributor

Botosio commented Oct 25, 2021

@Botosio make sure that you use unique form code when creating a form. Unique to previously created forms

@idormenco Got it, thank you! Is there a feature to display an error when validation doesn't pass?

@idormenco
Copy link
Member

hmmm ,don't think so. We could add one.
@aniri please advice

@aniri
Copy link
Member Author

aniri commented Oct 25, 2021

Yep, we should display the error in case the code is not unique. The validation was just implemented on the backend, so we'll have to add an issue for displaying the error message :D

@idormenco
Copy link
Member

@aniri I will create an issue

@idormenco
Copy link
Member

please see #359 and #360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment