Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark plugin as thread safe for parallel execution in maven 3.x #8

Open
dzwicker opened this issue Oct 1, 2013 · 3 comments
Open

Mark plugin as thread safe for parallel execution in maven 3.x #8

dzwicker opened this issue Oct 1, 2013 · 3 comments

Comments

@dzwicker
Copy link

dzwicker commented Oct 1, 2013

INFO] Building Risk Opportunity Map Application 1.0.0.0-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project *
[WARNING] * contains the following plugin(s) that have goals not marked *
[WARNING] * as @threadsafe to support parallel building. *
[WARNING] * While this /may/ work fine, please look for plugin updates *
[WARNING] * and/or request plugins be made thread-safe. *
[WARNING] * If reporting an issue, report it against the plugin in *
[WARNING] * question, not against maven-core *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadsafe in Risk Opportunity Map Application:
[WARNING] com.code54.mojo:buildversion-plugin:1.0.3
[WARNING] Enable debug to see more precisely which goals are not marked @threadsafe.
[WARNING] *****************************************************************

@dzwicker
Copy link
Author

dzwicker commented Dec 7, 2013

Any reaction would be nice. Is the Mojo thread safe? Or is there something that would break in a parallel execution?

@dobladez
Copy link
Member

dobladez commented Dec 9, 2013

Any patch would be even nicer ;-). Kidding...

The plugin is indeed thread-safe AFAIK: it has no state, and it invokes git only for read-only operations (git log basically).

Now, as funny as it might seam, marking it as "threadSafe" is not trivial due to the way the "Clojure mojo descriptor extractor" works: it does not recognize threadSafe and it must be modified upstream in other to do so. Unfortunately, I currently don't have the time to fix the "extractor" upstream and get the change accepted and published. I might do it some day.

As an ugly workaround, I guess I could simply modify the generated plugin.xml and re-publish it :-. I would hate to do that though.

@adamretter
Copy link

For reference the upstream source for the clojure-maven-mojo-descriptor-extractor can be found here: https://github.com/pallet/clojure-maven/tree/develop/mojo-descriptor-extractor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants