You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be preferable to use gitoxide's Git config implementation as it's surely more robust than what's currently in place. That should be considered as ad-hoc and a temporary workaround.
// TODO: figure out why this doesn't find the setting when used with `git -c`
// let private_key_path = config.string("icp.privateKey").ok_or_else(|| {
// anyhow!("failed to read icp.privateKey from git config. Set with `git config --global icp.privateKey <path to private key>`")
// })?;
@Byron – do you have any suggestions here? This isn't urgent but it would be a nice change (see below)
Once the custom config options we require in the icp namespace are confirmed as working using gitoxide (if possible) we should investigate if git -c http.proxy=http://localhost:9091 -c http.sslCAinfo=~/.proxyman/proxyman-ca.pem <command> then "just works" or if supporting that requires further changes.
The text was updated successfully, but these errors were encountered:
Since you use git-repository and presumably instantiate a Repository at some point, that .config_snapshot() can be used to access all on-disk configuration accordingly.
The -c parameter is tricky I checked the -c parameter and noticed that it is storing it in the GIT_CONFIG_PARAMETERS environment variable in a custom-quoted format which should make it possible to read it back to make it available via git-config.
Hello @paulyoung
I have checked this project and very interested in this
this project is very good
I would love to engage in your team and contribute in this project
It would be preferable to use gitoxide's Git config implementation as it's surely more robust than what's currently in place. That should be considered as ad-hoc and a temporary workaround.
git-remote-icp/crates/git-remote-helper/src/git/config/mod.rs
Lines 3 to 6 in c3f0f5c
@Byron – do you have any suggestions here? This isn't urgent but it would be a nice change (see below)
Once the custom config options we require in the
icp
namespace are confirmed as working using gitoxide (if possible) we should investigate ifgit -c http.proxy=http://localhost:9091 -c http.sslCAinfo=~/.proxyman/proxyman-ca.pem <command>
then "just works" or if supporting that requires further changes.The text was updated successfully, but these errors were encountered: