-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Padding on last elements #184
Comments
[#184] Signed-off-by: Em Barnard-Shao <[email protected]>
The current PR adds a margin bottom to the last child. However, that is leading to the padding from labels being removed (for every text input there is one label, which is technically the last p child, hence the removed padding). Some more investigation is needed to scope down which elements are being targeted when removing padding |
Discussed with @SymonneSingleton: This approach may not work with some elements with a lot of divs. For example these paragraphs in grid, should still have space between them when they're stacked on mobile. |
The first PR put:
on p tags and button classes. Due to the issues described above by @SymonneSingleton we're closing that PR. To move this forward it would probably be best to pair with a designer. |
When a paragraph or button is the last element in its div, it should have zero bottom padding. This is so that the contents of e.g. a slab can be centered horizontally.
The text was updated successfully, but these errors were encountered: