Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike on improvements to Form Builder #186

Closed
lkogler opened this issue May 19, 2020 · 2 comments
Closed

Spike on improvements to Form Builder #186

lkogler opened this issue May 19, 2020 · 2 comments

Comments

@lkogler
Copy link
Contributor

lkogler commented May 19, 2020

The goal is to understand how best to move forward with improvements to the Form Builder.

  • What would be the level of effort / complexity that would be required to extract the GCF form builder into Honeycrisp?
  • How could we create a more consistent / flexible interface for the form builder?
@lkogler lkogler changed the title Spike on adopting GCF form builder in Honeycrisp Spike on improvements to Form Builder Sep 1, 2020
@hartsick
Copy link
Contributor

hartsick commented Sep 1, 2020

A thing about the interface we'd like to change: require label_text and legend_text for all methods. We think we realistically won't use the Rails default fallbacks for labels, which was the motivation for making them optional.

@hartsick
Copy link
Contributor

Closing in favor of #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants