Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfa_checkbox adds an "is-disabled" class when the field is disabled, but there's no corresponding CSS class to style it #199

Open
hartsick opened this issue Aug 14, 2020 · 3 comments
Labels
bug Something isn't working needs-design

Comments

@hartsick
Copy link
Contributor

Right now if a cfa_checkbox in the FormBuilder is disabled, the method adds the is-disabled class but there is no corresponding CSS to style that class.

What is the styling we expect for a disabled checkbox?

I think the CSS styles should be here.

@hartsick hartsick added the bug Something isn't working label Aug 14, 2020
@bytheway875
Copy link
Contributor

Screen Shot 2021-02-26 at 3 29 53 PM

In GYR, we handled this by setting opacity to .5 for the entire checkbox, and adding a "not allowed" cursor when you hover. Wondering if something like that would be what we're going for @racheledelman

@bytheway875
Copy link
Contributor

The contrast is a little low -- maybe .65 opacity is a sweeter spot

@hartsick
Copy link
Contributor Author

hartsick commented Mar 19, 2021

@bytheway875 did you all style this using the is-disabled class? I'm planning to remove that class in the new form builder to reduce complication in the logic. I think this may be difficult to target using CSS since disabled happens at the input level and this styling is applied higher, but the class could easily be passed down with label classes (though could be easy to forget) or applied via Javascript (similar to how we're handling is-selected, though a bit different case). anyway, wanted to both give you a heads up and solicit your thoughts.

@hartsick hartsick mentioned this issue Mar 19, 2021
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-design
Projects
None yet
Development

No branches or pull requests

3 participants