Fyst 1222 remove screener questions from az flow #5039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mike Rotondo <[email protected]>
Co-authored-by: Mike Rotondo <[email protected]>
Co-authored-by: Mike Rotondo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
|
Heroku app: https://gyr-review-app-5039-1a35aef68f04.herokuapp.com/ |
Co-authored-by: Hugo Melo <[email protected]>
squanto
changed the title
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
Co-authored-by: Hugo Melo <[email protected]>
|
|
||
| context "with offboarded_from set in the session" do | ||
| render_views | ||
| let(:offboarded_from_path) do | ||
| StateFile::Questions::AzEligibilityResidenceController.to_path_helper | ||
| StateFile::Questions::NyEligibilityResidenceController.to_path_helper |
There was a problem hiding this comment.
🤔 hmm, why did y'all change out the controller referenced in this test to NY as opposed to another state that we support?
anisharamnani
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
thanks @mrotondo and @squanto! yay to deleting code 🎉
i do have one pebble-ish comment. considering that we don't support NY anymore, could the test be swapped out for another controller? if that's not doable, could we delete the test?
plus, if we do decide to completely remove NY one day. this would be another thing to clean up down the line.
Co-authored-by: Hugo Melo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
Remove screener questions from AZ flow
How to test?
Click get started in AZ
Confirm that you're redirect to the eligible page