Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nj 122 driver license #5045

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Nj 122 driver license #5045

wants to merge 11 commits into from

Conversation

mluedke2
Copy link
Contributor

@mluedke2 mluedke2 commented Nov 27, 2024

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/122

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • I reuse the existing state_id feature used by other states as much as possible, which is why this PR doesn't contain any code for XML input or building the form
  • The only overwrites were for the new names for driver license/state ID that our designs introduced

How to test?

  • Test with a single persona and an MFJ persona
  • You should always be asked the primary Driver License question, and spouse too if MFJ
  • XML and PDF filled with info if provided

Screenshots (for visual changes)

minimal_720.mov

Copy link

Heroku app: https://gyr-review-app-5045-efb03078e667.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5045 (optionally add --tail)

@mluedke2 mluedke2 marked this pull request as ready for review November 27, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant