-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#180] remove IOException from FileUtils signature #181
Conversation
ditto that will break a lot of stuff |
Still think it's worth it. I adds so much noise to Mojos (especially reports) that this is a great fix. |
Who is actually using PU outside of Codehaus or Maven space? |
I don't really think it matters. If it goes inside a major release, users will have to adjust, but the change makes sense to me. |
FWIW, those have to be reflected in maven-utils as well.
in this case, I was using it for the taglist-maven-plugin. Someone was using it in For this reason, I created yet another issue: https://issues.apache.org/jira/browse/MNG-7393 I do not think throwing a |
Question: When the code will move to NIO 2, will |
Good point. Not at PC today, but from memory: yes, probably. |
If this evaluates to true, then this PR should be dropped. |
@bmarwell Do you still want to hold onto this PR although I have a provided a reason not to? |
@michael-o Good question. I initially opened this issue because of how the maven report works. But we can deal with it later as well. |
fixes #180
Sadly, this is a breaking change – make it a new major version (and add other similar changes, too!).