Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have you considered using kotlinx.serialization? #7

Open
jschneidereit opened this issue Oct 8, 2020 · 6 comments
Open

Have you considered using kotlinx.serialization? #7

jschneidereit opened this issue Oct 8, 2020 · 6 comments

Comments

@jschneidereit
Copy link

jschneidereit commented Oct 8, 2020

If you're not opposed, would you accept a pull request?

(https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/json.md#subtypes-of-json-elements)

@codeniko
Copy link
Owner

codeniko commented Oct 8, 2020

Hi! Interesting, I'm not familiar with that one and am open to a pull request. It will definitely be nice to have a full kotlin solution rather than my using of Jackson internally.

Feel free to go at it, I have plenty of unit tests to ensure outputs are what they are expected to be. Hopefully the performance will be better or atleast on par than with Jackson; There is a benchmark test in the repo we can use to verify that and I can offer some help too

@jschneidereit
Copy link
Author

Cool! I'm trying to go full kotlin in my project as well and get rid of json-path and json-path-assert (wanna take a stab? 😛). As I understand it kotlinx.serialization is certainly faster than Jackson in terms of unmarshalling, but I'm not sure about using dictionaries etc.

I'll take a look tomorrow and see how much work it might be 👍

@jschneidereit
Copy link
Author

Also, are you opposed to a more recent version of gradle?

@codeniko
Copy link
Owner

codeniko commented Oct 9, 2020

Not opposed, go for it. I would take a stab at your project but I'm currently busy with some other side projects haha

@jschneidereit
Copy link
Author

Cool. I got started on the new gradle version (kinda painful with jacoco migrations and such) and once I'm done with that I'll go for the kotlinx.serialization bit! 👍

@erawhctim
Copy link

erawhctim commented Aug 26, 2022

@jschneidereit did you ever make any progress porting this to kotlinx.serialization?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants