npm run build:vscode fails with multiple syntax errors

[Papilionidae]

Description:

I encountered multiple syntax errors when running npm run build:vscode in my local environment. Here are the details of my setup:

Node.js: v20.18.0
npm: 10.8.2
code-server: v4.95.1
VSCode: 1.95.1
Error Logs:

[09:45:00] Starting bundle-vscode-reh-web ...
[09:45:00] Bundled entry point: vs/workbench/api/node/extensionHostProcess...
[09:45:00] Bundled entry point: vs/platform/files/node/watcher/watcherMain...
[09:45:00] Bundled entry point: vs/platform/terminal/node/ptyHostMain...
[09:45:00] Bundled entry point: vs/editor/common/services/editorSimpleWorkerMain...
[09:45:00] Bundled entry point: vs/workbench/api/worker/extensionHostWorkerMain...
[09:45:00] Bundled entry point: vs/workbench/contrib/notebook/common/services/notebookSimpleWorkerMain...
[09:45:00] Bundled entry point: vs/workbench/services/languageDetection/browser/languageDetectionSimpleWorkerMain...
[09:45:01] Bundled entry point: vs/workbench/services/search/worker/localFileSearchMain...
✘ [ERROR] Expected ")" but found ".2732"

    out-build/vs/workbench/api/common/extHostWorkspace.js:247:44:
      247 │                 this.q.$showMessage(Severity.2732(null"Extension '{0}' failed to update workspace folders: {1}", extName, error.toString()), options, []);
          │                                             ~~~~~
          ╵                                             )

... (more similar errors)

[09:45:02] 'vscode-reh-web-linux-x64-min' errored after 1.25 h
[09:45:02] Error: Build failed with 1 error:
out-build/vs/platform/files/common/files.js:186:26: ERROR: Expected ";" but found "'unknownError'"
    at failureErrorWithLog (/data/code-server/lib/vscode/build/node_modules/esbuild/lib/main.js:1472:15)
    at /data/code-server/lib/vscode/build/node_modules/esbuild/lib/main.js:945:25
    at runOnEndCallbacks (/data/code-server/lib/vscode/build/node_modules/esbuild/lib/main.js:1315:45)
    at buildResponseToResult (/data/code-server/lib/vscode/build/node_modules/esbuild/lib/main.js:943:7)
    at /data/code-server/lib/vscode/build/node_modules/esbuild/lib/main.js:970:16
    at responseCallbacks.<computed> (/data/code-server/lib/vscode/build/node_modules/esbuild/lib/main.js:622:9)
    at handleIncomingPacket (/data/code-server/lib/vscode/build/node_modules/esbuild/lib/main.js:677:12)
    at Socket.readFromStdout (/data/code-server/lib/vscode/build/node_modules/esbuild/lib/main.js:600:7)
    at Socket.emit (node:events:519:28)
    at Socket.emit (node:domain:551:15)
fatal error: all goroutines are asleep - deadlock!
⠙
goroutine 1 [chan receive]:
github.com/evanw/esbuild/internal/helpers.(*ThreadSafeWaitGroup).Wait(...)
        github.com/evanw/esbuild/internal/helpers/waitgroup.go:36
main.runService.func2()
        github.com/evanw/esbuild/cmd/esbuild/service.go:114 +0x51
main.runService(0x1)
        github.com/evanw/esbuild/cmd/esbuild/service.go:160 +0x517
main.main()
        github.com/evanw/esbuild/cmd/esbuild/main.go:241 +0x9d9

goroutine 18 [chan receive]:
main.runService.func1()
        github.com/evanw/esbuild/cmd/esbuild/service.go:98 +0x45
created by main.runService in goroutine 1
        github.com/evanw/esbuild/cmd/esbuild/service.go:97 +0x1db

goroutine 19 [chan receive]:
main.(*serviceType).sendRequest(0xc000125ef0, {0x954100, 0xc00877e4e0})
        github.com/evanw/esbuild/cmd/esbuild/service.go:192 +0x12b
main.runService.func3()
        github.com/evanw/esbuild/cmd/esbuild/service.go:125 +0x3e
created by main.runService in goroutine 1
        github.com/evanw/esbuild/cmd/esbuild/service.go:122 +0x31b.
...

[code-asher]

Just to check, you applied the patches with quilt apply -a and ran npm install without any errors?

[Papilionidae]

Both npm install and npm push -a did not report any errors. Additionally, when I run npm run watch, it works perfectly fine without any issues. I suspect that the issue lies with the patch applied by the code's nls module to the localize method.

[Papilionidae]

Thank you for your response. I tried modifying the 'compile-build' task in the file lib/vscode/build/gulpfile.compile.js yesterday by changing the disableMangle parameter from false to true, and after that, I was able to build successfully.

[code-asher]

Interesting!