Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: bot does not send a release announcement if the last sent version number is higher than the current one #9

Closed
phorcys420 opened this issue May 27, 2024 · 3 comments

Comments

@phorcys420
Copy link
Member

While this was intentional at first, releases of mainline versions on coder/coder happen in parallel with stable ones, which means you can have v2.11.0, then v2.10.3, then v2.11.1, and so on.

This should be fixed, the embeds should also mention whether the release is mainline or stable to avoid confusion from users.

@phorcys420
Copy link
Member Author

I'm rewriting this feature in the context of the TypeScript rewrite (#10) and I'm wondering if we really do want to fix this?
Do we really want to publish an announcement every time a mainline version is released?

Another question I had in mind, do we want to publish new versions of our other software? like code-server and envbuilder?

cc @matifali do you have an opinion on this?

@matifali
Copy link
Member

I suggest we combine the mainline and stable announcement in 1 post and skip for patch releases.

Also no need to announce other projects as this will be just noise.

@phorcys420
Copy link
Member Author

Currently posting every release, will try to differentiate stable from security/patch releases in the future but as seen w/ Cian it's complicated w/ our current way of releasing things.

This has been moved out of the bot in favor of a Zap to avoid having to expose a webhook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants